Surface studio.deploy return causes and live URL instead of generic HOLD residuals by Copilot · Pull Request #2041 · groupthinking/EventRelay

Copilot · 2026-09-18T21:10:03Z

Canonical issue

Canonical issue is linked by system automation.

Outcome

Studio deploy status no longer degrades to generic unread-return placeholders when workflow return reads fail. Failed runs now surface the deepest real cause, and readable live URLs embedded in failure/cause payloads are passed through as deploy evidence.

Scope

Included:
- Error unwrapping in workflow status parsing: workflowReturnErrorMessage now traverses nested cause chains and prefers specific messages over wrapper text (Failed to read workflow return value, Workflow run failed).
- Live URL extraction from failure payloads: added workflowReturnLiveUrl to traverse nested error/cause objects and recover verified backend-supplied https live URLs.
- Studio deploy status route behavior: /api/workflows/studio-deploy/[runId] now emits { kind: 'live', live_url } when a live URL exists in return-read failures; otherwise emits the real failure cause.
- Regression coverage: added focused tests for nested-cause message selection and live URL passthrough from unread return-value failures.
- Example:
```
// route.ts catch path
const live_url = workflowReturnLiveUrl(err);
if (live_url) {
  body.result = { kind: 'live', live_url };
} else {
  body.error = workflowReturnErrorMessage(err);
}
```
Explicitly excluded:
- No changes to Origin G.A.T.E. decision policy.
- No changes to deploy orchestration semantics or preflight authorization flow.
- No unrelated UI workflow changes.

Risk

Risk level: low
Failure mode: malformed nested error objects could still fall back to generic top-level messaging if no specific message/url is recoverable.
Rollback: revert apps/web/src/lib/studio-workflow.ts and apps/web/src/app/api/workflows/studio-deploy/[runId]/route.ts (plus companion tests).

Verification

List exact automated and manual checks, tied to the current head SHA.

Focused tests
- npm --workspace=apps/web run test -- --run src/lib/__tests__/studio-workflow.test.ts src/app/api/workflows/studio-deploy/[runId]/__tests__/route.test.ts
- npm --workspace=apps/web run test -- --run src/lib/__tests__/studio-deploy.test.ts src/lib/__tests__/gate-transition.test.ts src/components/__tests__/OneLoopStudio.gate.test.tsx
Required CI
Review threads resolved

Production evidence

Not applicable in this sandbox session: change is limited to web workflow-status parsing and route response shaping; no production deployment or runtime receipt was executed here.

Agent handoff

One canonical issue is linked
No competing PR implements the same issue
Acceptance criteria are satisfied
Required checks pass on the current head
Human decision is requested only for product, security, irreversible infrastructure, or production approval

Fixes Fix Studio deploy to surface return causes instead of generic HOLD #1851

coderabbitai · 2026-09-18T21:10:08Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: groupthinking/EventRelay/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 16bc0a26-f7f0-4dd0-bb99-e3d605468e03

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>

vercel · 2026-09-18T21:21:01Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
v0-uvai	Ready	Preview, v0	Sep 18, 2026 9:47pm UTC

github-actions · 2026-09-18T22:26:10Z

🔍 PR Validation

⚠️ PR title should follow conventional commits format

Copilot

Copilot review overview

🟡 Changes recommended

Error traversal can miss nested payloads, select shallow wrappers, or misclassify unrelated HTTPS URLs as deploy evidence.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 3

Open (4)

Restrict live URL recovery to deployment receipt fields · New
Preserve detailed causes when matching generic wrapper messages · New
Select the deepest non-generic cause · New
Traverse nested error objects for deployment receipts · New

What changed in this PR

Addresses #1851 by recovering deploy failure causes and live URLs from workflow errors.

Changes:

Unwraps nested workflow error causes.
Recovers live deployment URLs from failed return reads.
Adds regression tests for both behaviors.

File	Description
`studio-workflow.ts`	Adds nested error and URL extraction.
`studio-workflow.test.ts`	Tests nested cause selection.
`route.ts`	Returns recovered live evidence or failure details.
`route.test.ts`	Tests live URL passthrough.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+    const liveUrl = extractBackendLiveUrl(current);
+    if (liveUrl) return liveUrl;


+const GENERIC_WORKFLOW_RETURN_RE =
+  /failed to read workflow return value|failed to read workflow run|workflow run failed/i;


+export function workflowReturnErrorMessage(err: unknown): string {
+  const messages: string[] = [];
+  collectWorkflowReturnMessages(err, messages);
+  const specific = messages.find((message) => !GENERIC_WORKFLOW_RETURN_RE.test(message));


+    if (current && typeof current === 'object') {
+      queue.push((current as { cause?: unknown }).cause);
+    }


Initial plan

dea43e9

Copilot AI assigned Copilot and groupthinking Sep 18, 2026

Copilot started work on behalf of groupthinking September 18, 2026 21:11 View session

Copilot AI linked an issue Sep 18, 2026 that may be closed by this pull request

Fix Studio deploy to surface return causes instead of generic HOLD #1851

Open

fix: surface studio deploy return causes and live URLs

d80391d

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix Studio deploy to surface return causes instead of generic HOLD~~ Surface studio.deploy return causes and live URL instead of generic HOLD residuals Sep 18, 2026

Copilot finished work on behalf of groupthinking September 18, 2026 21:16

Copilot AI requested a review from groupthinking September 18, 2026 21:29

vercel Bot deployed to Preview September 18, 2026 21:47 View deployment

github-actions Bot added javascript Pull requests that update javascript code tests labels Sep 18, 2026

groupthinking approved these changes Sep 19, 2026

View reviewed changes

groupthinking marked this pull request as ready for review September 19, 2026 00:07

Copilot AI balanced review requested due to automatic review settings September 19, 2026 00:07

Copilot started reviewing on behalf of groupthinking September 19, 2026 00:08 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Navigation Menu

Surface studio.deploy return causes and live URL instead of generic HOLD residuals - #2041

Surface studio.deploy return causes and live URL instead of generic HOLD residuals#2041
groupthinking with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-studio-deploy-return-causes

Copilot AI commented Sep 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 18, 2026 •

edited

Loading

Review skipped

Uh oh!

vercel Bot commented Sep 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		const liveUrl = extractBackendLiveUrl(current);
		if (liveUrl) return liveUrl;

		const GENERIC_WORKFLOW_RETURN_RE =
		/failed to read workflow return value\|failed to read workflow run\|workflow run failed/i;

Conversation

Copilot AI commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Canonical issue

Outcome

Scope

Risk

Verification

Production evidence

Agent handoff

Uh oh!

coderabbitai Bot commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

vercel Bot commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 18, 2026

🔍 PR Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Sep 18, 2026 •

edited

Loading

coderabbitai Bot commented Sep 18, 2026 •

edited

Loading

vercel Bot commented Sep 18, 2026 •

edited

Loading