Use canonical client-routed Studio sign-in handoffs - #2033
groupthinking with Copilot wants to merge 2 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: groupthinking/EventRelay/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔍 PR Validation |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Repository policy requires individual human approval for authentication changes.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns legacy Studio sign-in handoffs with the canonical encoded /studio callback.
Changes:
- Reuses one canonical login URL for links and unauthorized deploy redirects.
- Adds regression coverage for both handoff paths.
| File | Description |
|---|---|
VideoWorkflowStudio.tsx |
Uses the canonical Studio path for sign-in routing. |
VideoWorkflowStudio.test.tsx |
Verifies encoded callback URLs. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Canonical issue
Outcome
Studio unauthorized handoffs now use the same canonical login callback shape as the rest of the app, avoiding raw callback strings in the legacy Studio surface while preserving return-to-
/studiobehavior.VideoWorkflowStudionow derives its login URL fromCANONICAL_STUDIO_PATHandencodeURIComponent(...)instead of embedding/login?callbackUrl=/studio.router.push(...)path and the headerSign inlink now share the same canonical URL construction.Scope
apps/web/src/components/VideoWorkflowStudio.tsxapps/web/src/components/__tests__/VideoWorkflowStudio.test.tsxOneLoopStudio/StudioAuthNavLinkbehavior beyond compatibility verificationRisk
VideoWorkflowStudiologin URL constant and regression assertion.Verification
List exact automated and manual checks, tied to the current head SHA.
eb5b826:npm run test --workspace=apps/web -- src/components/__tests__/VideoWorkflowStudio.test.tsx src/components/__tests__/StudioAuthNavLink.test.tsx src/components/__tests__/OneLoopStudio.gate.test.tsxeb5b826:npm run lint --workspace=apps/web -- src/components/VideoWorkflowStudio.tsx src/components/__tests__/VideoWorkflowStudio.test.tsxeb5b826:npm --workspace=apps/web run type-checkProduction evidence
Not applicable for this change set; this is a client-side routing consistency fix with no deploy-state or runtime-state change to capture in isolation.
Agent handoff