docs: add evidence-oriented sprint QA checklist - #1991
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: groupthinking/EventRelay/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
There was a problem hiding this comment.
🟡 Changes recommended
Several evidence references are nonexistent, unverifiable, authentication-dependent, or already stale.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a documentation-only sprint QA checklist covering UI, OAuth, security, and release evidence.
Changes:
- Defines automated and manual QA checks.
- Separates blockers from known limitations.
- Links supporting sprint references.
File summaries
| File | Description |
|---|---|
docs/SPRINT_QA_CHECKLIST.md |
Adds the sprint QA checklist and evidence register. |
Review details
Suppressed comments (5)
docs/SPRINT_QA_CHECKLIST.md:44
- “Documented local test equivalents” does not identify any document, command, or observation, contrary to the issue's requirement that every item name its exact evidence source. Link the concrete local substitute or remove this item; the correct source cannot be inferred from the checklist.
- *Evidence:* Documented local test equivalents for preview environments.
docs/SPRINT_QA_CHECKLIST.md:51
gh pr viewnormally requires GitHub CLI authentication, so this conflicts with the acceptance criterion that another reviewer can execute the checklist without hidden credentials. The public PR page exposes the draft badge without requiring a token.
- *Evidence:* `gh pr view <number> --json isDraft`
docs/SPRINT_QA_CHECKLIST.md:60
- The 77.29% result has no run URL, commit, date, report, or exact command, and that number appears nowhere else in the repository. Because this is presented as a current release blocker, attach the exact CI/local evidence at a named revision so reviewers can distinguish a current failure from a stale result.
- **Backend Coverage Gate:** The backend test suite executed successfully, but aggregate coverage (77.29%) fell below the `fail_under = 88.1833` threshold in `pyproject.toml`. This blocks a clean CI pipeline.
docs/SPRINT_QA_CHECKLIST.md:61
- This status is already stale: GitHub reports PR #1980 merged at 2026-09-18 20:51 UTC, while PR #1978 is open and unmerged but no longer marked draft. Keeping both under “Unmerged Drafts” overstates the current blockers, which is the failure mode this PR explicitly aims to avoid.
- **Unmerged Drafts:** PR #1978 (OAuth fix) and PR #1980 (Agenda) remain unmerged drafts.
docs/SPRINT_QA_CHECKLIST.md:71
- These link labels repeat the stale draft status: GitHub currently shows #1978 as open/non-draft and #1980 as merged. Use neutral/current labels so the reference list does not make false lifecycle claims.
- [Draft PR #1978: recover failed Google sign-in initiation](https://github.com/groupthinking/EventRelay/pull/1978)
- [Draft PR #1980: add evidence-backed sprint demo agenda](https://github.com/groupthinking/EventRelay/pull/1980)
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - [ ] **URL Handoff:** Submit a valid YouTube URL and confirm it navigates to `/studio?video=...`. | ||
| - *Evidence:* `npm --workspace=eventrelay-web test -- src/lib/__tests__/studio-handoff.test.ts` | ||
| - [ ] **Invalid Input:** Submit an invalid URL and confirm the existing error renders as an accessible alert. | ||
| - *Evidence:* Manual observation and `HomePasteForm` component tests. |
| - [ ] **Sandbox Origin:** Confirm cross-origin requests are correctly rejected. | ||
| - *Evidence:* `npm --workspace=eventrelay-web test -- src/lib/__tests__/sandbox-origin.test.ts` (if applicable) or manual CORS verification. |
| - [ ] **Draft PRs:** Changes are submitted as draft pull requests only. | ||
| - *Evidence:* `gh pr view <number> --json isDraft` | ||
| - [ ] **No Secrets:** No credentials or deployment changes are committed. | ||
| - *Evidence:* `git diff --check` and manual review of the diff. |
Canonical issue
Closes #1990
Outcome
Adds an internal QA checklist for the current sprint tasks. The document relies on exact automated commands and manual observations, separating release blockers from known limitations without modifying application behavior.
Scope
docs/SPRINT_QA_CHECKLIST.mdwith evidence-oriented checks for responsive layout, OAuth retry flows, security boundaries, and repository hygiene.Risk
Verification
git diff --checkand one-H1 check passed.Production evidence
Not applicable. This documentation-only PR does not create a deployment or a production claim.
Agent handoff