fix(auth): restore Google sign-in retry state - #1986
Closed
groupthinking wants to merge 1 commit into
Closed
groupthinking wants to merge 1 commit into
groupthinking wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
No GitHub issue applies. The canonical sprint task is Notion: Fix login bug.
Outcome
A rejected or non-navigating Google sign-in initiation restores an enabled Continue with Google button and announces a generic, non-sensitive error. A browser navigation handoff remains protected against duplicate submission.
Scope
GoogleSignInButton.Risk
window.location.hrefcould be shown as retryable instead of pending.de2994fbe809c85f2543efecfaf741e2a9233eb9.Verification
Validation performed against the content committed at
de2994fbe809c85f2543efecfaf741e2a9233eb9:npm --workspace=eventrelay-web run test -- src/app/login/GoogleSignInButton.test.tsx— 3 tests passed.npx turbo run test --force— 128 files passed; 1,216 tests passed and 27 skipped.npm --workspace=eventrelay-web run type-check.npm --workspace=eventrelay-web run lint— 0 errors; 3 existing warnings in unrelated components.git diff --cached --checkand a staged credential-pattern scan before commit.pytest tests/could not start because the checkout has nopytestexecutable or local virtual environment. This frontend-only change does not alter backend code.Production evidence
Not applicable. This draft changes client-side recovery state and does not deploy, access production credentials, or perform a real Google sign-in.
Agent handoff