Skip to content

Fix test cleaning (#1175) - #1176

Closed
SlimaneAmar wants to merge 1 commit into
mainfrom
fix_test_cleaning
Closed

SlimaneAmar wants to merge 1 commit into
mainfrom
fix_test_cleaning

Conversation

@SlimaneAmar

Copy link
Copy Markdown
Contributor

PR Summary

Co-authored-by: Slimane AMAR <slimane.amar_externe@rte-france.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The test teardown now deletes the network-modification tree for each study returned by studyRepository.findAll() before deleting all studies.

Changes: Test cleanup

Layer / File(s) Summary
Study teardown cleanup
src/test/java/org/gridsuite/study/server/NetworkModificationReferencingInfosUpdateTest.java
tearDown calls doDeleteTree for each study ID before the existing deleteAll() cleanup.

Suggested reviewers: souissimai

Merge Risk: Minimal · up to 6aee6

This is a test-only teardown change with no production impact and no remaining merge-blocking risk.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description contains only the template placeholder comments and an empty 'PR Summary' section. It does not describe the change. However, the check is lenient and the description is not off-topic. … Add a short PR Summary that states what the tearDown change does, what it did before, and any notes for reviewers.
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title "Fix test cleaning (#1175)" matches the changeset. The only change adds a step to tearDown that deletes each study's network-modification tree before deleting all studies, which is a test cl…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Fix test cleaning (#1175)" matches the changeset. The only change adds a step to tearDown that deletes each study's network-modification tree before deleting all studies, which is a test cleanup fix. The title is brief but specific enough. It does not name the exact change (network-modification tree deletion), but it names the correct area.

Full details: Description check

Explanation

The description contains only the template placeholder comments and an empty 'PR Summary' section. It does not describe the change. However, the check is lenient and the description is not off-topic. It gives no detail, so it is not clearly related to the changeset in content, but it is not unrelated either.

Resolution

Add a short PR Summary that states what the tearDown change does, what it did before, and any notes for reviewers.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 738d2489-fc3f-4e3e-aa47-c6e12f322743
Commits

Reviewing files that changed from the base of the PR and between 3e30899 and 6aee6a5.

Files selected for processing: 1

  • src/test/java/org/gridsuite/study/server/NetworkModificationReferencingInfosUpdateTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@SlimaneAmar
SlimaneAmar deleted the fix_test_cleaning branch November 13, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant