Skip to content

fix(layered): align differently sized blocks by center - #348

Open
SimbiozizV wants to merge 1 commit into
mainfrom
layered_fix
Open

SimbiozizV wants to merge 1 commit into
mainfrom
layered_fix

Conversation

@SimbiozizV

@SimbiozizV SimbiozizV commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Summary by Sourcery

Align layered graph nodes and connection routes by block centers across variable sizes while preserving existing layout behavior.

New Features:

  • Align layered layouts and routed edges by the centers of differently sized blocks.
  • Add a variable-size layered layout Storybook example.

Bug Fixes:

  • Correct spacing and alignment calculations for nodes with varying dimensions while preserving standard-node geometry.

Enhancements:

  • Support separate virtual-node width and height defaults, while retaining the legacy virtual-node size option for compatibility.
  • Clarify layered layout spacing option semantics for inter-column and intra-column gaps.

Tests:

  • Add layout and integration coverage for center alignment, variable node gaps, wide layers, custom virtual-node sizes, and unchanged standard geometry.

@sourcery-ai

sourcery-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Reviewer's Guide

The PR makes layered layouts dimension-aware: node alignment, intra-layer spacing, inter-layer clearance, and returned coordinates now account for variable block sizes, while edge routing uses separate virtual-node dimensions. It adds regression and integration tests plus a Storybook example and corrected option documentation.

File-Level Changes

Change Details Files
Update the layered layout algorithm to account for each node’s actual dimensions when aligning and spacing nodes.
  • Calculate vertical separation from the two nodes’ half-heights plus the configured gap.
  • Align alternative coordinate systems using top and bottom bounds rather than raw center coordinates.
  • Preserve horizontal clearance after wide layers and retain standard-node geometry.
  • Normalize returned node positions so the layout’s coordinates remain compatible with block top-left positions.
src/plugins/layered/layout.ts
src/plugins/layered/layout.test.ts
Route edge endpoints through correctly dimensioned virtual-node centers.
  • Accept separate virtual-node width and height values while retaining the deprecated square-size fallback.
  • Pass configured default dimensions from the layout hook to the converter.
  • Add integration coverage for differently sized blocks and custom virtual-node defaults.
src/plugins/layered/converters/layeredConverter.ts
src/plugins/layered/hooks/useLayeredLayout.ts
src/plugins/layered/hooks/useLayeredLayout.integration.test.ts
Add a variable-size layered graph example and update option documentation.
  • Provide a Storybook configuration and story containing varied node dimensions and merges.
  • Correct descriptions of horizontal and vertical gap semantics to match the implementation.
  • Update the story component to render arbitrary layout configurations and use complete effect dependencies.
src/stories/plugins/layered/config.ts
src/stories/plugins/layered/layered.stories.tsx
src/plugins/layered/types/index.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@gravity-ui-bot

Copy link
Copy Markdown
Contributor

Preview is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants