fix(camera): make wheel zoom steps reciprocal - #347
Merged
Merged
Conversation
Reviewer's GuideWheel zoom now applies signed deltas in log-scale space via an exponential multiplier, so equal opposite wheel steps return to the original scale while SPEED and STEP remain configurable. The configuration documentation is updated and an E2E regression test verifies reversibility. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Preview is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous wheel zoom formula used
currentScale * (1 - dScale). Equal zoom-in and zoom-out wheel steps therefore used(1 + d)and(1 - d)factors and did not return to the original scale.This changes wheel zoom to apply the signed delta in log-scale space with
currentScale * exp(-dScale). Relative zoom speed remains configurable throughSPEEDandSTEP, while opposite steps become reciprocal.Changes
Camera.handleZoom;SPEEDandSTEP;Validation
npm run lintnpm run test:unit -- --runInBandnpm run test:e2e -- camera-control.spec.ts— 7 passednpm run e2e:buildgit diff --checkSummary by Sourcery
Make wheel zoom steps reciprocal by applying camera scale changes in log-scale space.
Bug Fixes:
Enhancements:
Documentation:
Tests: