User-facing tinytheme_get() function + restore plot region after theme - #738
Merged
Merged
Conversation
- An ephemeral theme's margins live only in the `before.plot.new` hook, so rolling it back left `par(plt)` describing a different region than was drawn into. - Base R recomputes the device clip rect from `par()` whenever `xpd` changes, silently truncating anything added afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #629
Follow-up on two good points made by @bastistician in this comment, after I'd already closed the issue.
tinytheme_get()convenience function to grab the name of the current theme.type_v/hlineand co. correctly reach the axis after atext()call. This ended up being slightly trickier to catch/and plug. The underlying issue is that a theme's margins are applied through abefore.plot.newhook, so rolling the theme back on exit leftpardescribing a different plot region than the one that was drawn into. Meanwhile, base R only recomputes the device clipping rectangle whenxpdchanges, so anything drawn after an interveningxpdtoggle (e.g.text()-based, but alsobox(), etc.) was clipped short.