[edandavi]

No description provided.

[edandavi]

Notes:

json/v2 has changed the interfaces of Serialize and Deserialize:

func Marshal(in any, opts ...Options) (out []byte, err error)
func Unmarshal(in []byte, out any, opts ...Options) (err error)

Should we update our interfaces accordingly (with json.Options)?

Alternatively, ToJson and FromBody could use json/v2 directly, without the Serialize interfaces. This would allow us to use UnmarshalRead, avoiding an extra buffer allocation when reading the response body, as shown below:

func ToJson(v any, opts ...json.Options) requests.ResponseHandler {
	return func(res *http.Response) error {
		return json.UnmarshalRead(res.Body, v, opts...)
	}
}

Please let me know what you think
Thank you.

[earthboundkid]

I have some uncommitted changes with this on my computer as well. Will push it when I get the chance. I think the de/serializer interface can stay the same, and just wrap jsonv2.

[earthboundkid]

See c6db4ba