Skip to content

Preserve escaped slashes in the base path #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
earthboundkid merged 2 commits into from
Nov 9, 2026
Merged

Preserve escaped slashes in the base path #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
785e1d9
Preserve escapes when resolving relative paths
yuefdev Oct 18, 2026
d864148
Merge branch 'main' into fix/escaped-base-path
earthboundkid Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core_url.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ func (ub *urlBuilder) URL() (u *url.URL, err error) {
)
u.Host = cmp.Or(ub.host, u.Host)
for _, p := range ub.paths {
u.Path = u.ResolveReference(&url.URL{Path: p}).Path
resolved := u.ResolveReference(&url.URL{Path: p})
u.Path, u.RawPath = resolved.Path, resolved.RawPath
}
if len(ub.params) > 0 {
q := u.Query()
Expand Down
10 changes: 10 additions & 0 deletions core_url_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,16 @@ var PathCases = map[string]struct {
[]string{"b/", "c/", "/d"},
"https://example/d",
},
"escaped-base-segment": {
"https://example/a%2Fb/",
[]string{"c"},
"https://example/a%2Fb/c",
},
"escaped-base-parent": {
"https://example/a%2Fb/c/",
[]string{"../d"},
"https://example/a%2Fb/d",
},
}

func TestCorePath(t *testing.T) {
Expand Down