Simplify CpuCache definition and symbols - #981
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_983042180
branch
5 times, most recently
from
September 18, 2026 09:23
6116aed to
ae7d838
Compare
Remove unnecessary cpu_cache_internal namespace and CpuCache class forwarding. It complicates code, and makes symbols insanely long. Perf cannot show most tcmalloc symbols even with max scrolling (1K or something). You just something like: tcmalloc::tcmalloc_internal::cpu_cache_internal<tcmalloc::tcmalloc_internal::cpu_cache_internal<tcmalloc::tcmalloc_internal::cpu_cache_internal... PiperOrigin-RevId: 983764339
copybara-service
Bot
force-pushed
the
test_983042180
branch
from
September 18, 2026 10:29
ae7d838 to
b66200b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify CpuCache definition and symbols
Remove unnecessary cpu_cache_internal namespace and CpuCache class forwarding.
It complicates code, and makes symbols insanely long. Perf cannot show most
tcmalloc symbols even with max scrolling (1K or something). You just something like:
tcmalloc::tcmalloc_internal::cpu_cache_internal<tcmalloc::tcmalloc_internal::cpu_cache_internal<tcmalloc::tcmalloc_internal::cpu_cache_internal...