Add a flag to make the size class generator output bytes used per class. - #977
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This is in preparation for computing and reporting external fragmentation; it is good to have the usage numbers as reference to see that the relative calculations actually make sense. To this end, we simplify the dynamic programming a bit, where instead of sending all the fields of the OptimalStruct around, we just send the struct itself. (This makes it easier and cleaner to add more reporting fields to it in the future.) We also need to make the Bytes field non-cumulative, but this is simple. PiperOrigin-RevId: 981758751
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a flag to make the size class generator output bytes used per class.
This is in preparation for computing and reporting external fragmentation;
it is good to have the usage numbers as reference to see that the
relative calculations actually make sense. To this end, we simplify the
dynamic programming a bit, where instead of sending all the fields of
the OptimalStruct around, we just send the struct itself. (This makes it
easier and cleaner to add more reporting fields to it in the future.)
We also need to make the Bytes field non-cumulative, but this is simple.