Optimize HugePageFiller::RecordLifetime and cache lifetime bucket bounds. - #945
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…nds. Eliminate per-release clock_.freq() calls and absl::Duration round-trips in HugePageFiller::RecordLifetime under pageheap_lock by precomputing ms_per_cycle_ (1000.0 / clock_.freq()) in HugePageFiller's constructor and passing elapsed milliseconds directly to LifetimeBucketNum(int64_t). Replace the 72-byte instance array lifetime_bucket_bounds_[9] in UsageInfo and HugePageFiller with static constexpr kLifetimeBucketBounds. Combined with the 8-byte ms_per_cycle_ field, this reduces HugePageFiller size by exactly 64 bytes (one cache line), preserving 64-byte cache-line alignment for all subsequent members in HugePageAwareAllocator while eliminating constructor loop overhead. PiperOrigin-RevId: 982641116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize HugePageFiller::RecordLifetime and cache lifetime bucket bounds.
Eliminate per-release clock_.freq() calls and absl::Duration round-trips in
HugePageFiller::RecordLifetime under pageheap_lock by precomputing ms_per_cycle_
(1000.0 / clock_.freq()) in HugePageFiller's constructor and passing elapsed
milliseconds directly to LifetimeBucketNum(int64_t).
Replace the 72-byte instance array lifetime_bucket_bounds_[9] in UsageInfo and
HugePageFiller with static constexpr kLifetimeBucketBounds. Combined with the
8-byte ms_per_cycle_ field, this reduces HugePageFiller size by exactly 64 bytes
(one cache line), preserving 64-byte cache-line alignment for all subsequent
members in HugePageAwareAllocator while eliminating constructor loop overhead.