Use GetNumericProperty and shard limit_test. - #899
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_981778430
branch
from
September 17, 2026 01:28
aecfaff to
3c3414b
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_981778430
branch
8 times, most recently
from
September 17, 2026 02:38
e342f92 to
dfcc793
Compare
In `limit_test` (`45.2s` max duration in `-c dbg`): - Tests repeatedly invoke `GetStats()` and `GetStatsInPbTxt()` (allocating and formatting 3 MiB text and pbtxt buffers) and `DumpHeapStats()` on allocation milestones, performing expensive string formatting and regex matching. - `LimitRespected` allocates and frees 4 GiB in 16 KiB chunks (`524,288` operations). Replace `GetStats()` / `GetStatsInPbTxt()` string matching with `MallocExtension::GetNumericProperty`, remove `DumpHeapStats()`, set `kLim` to 1 GiB in `LimitRespected` (keeping all other test limits unchanged), and add `shard_count = 11`. This reduces max shard execution time across all variants in `-c dbg` from `45.2s` to `2.60s` (`< 5.0s`) with 0 flakes across 300 runs (`100/100` in `-c dbg`, `-c fastbuild`, and `-c opt` under `blase --configs=none`). PiperOrigin-RevId: 981778430
copybara-service
Bot
force-pushed
the
test_981778430
branch
from
September 17, 2026 02:48
dfcc793 to
57ccf24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use GetNumericProperty and shard limit_test.
In
limit_test(45.2smax duration in-c dbg):GetStats()andGetStatsInPbTxt()(allocating and formatting 3 MiB text and pbtxt buffers) andDumpHeapStats()on allocation milestones, performing expensive string formatting and regex matching.LimitRespectedallocates and frees 4 GiB in 16 KiB chunks (524,288operations).Replace
GetStats()/GetStatsInPbTxt()string matching withMallocExtension::GetNumericProperty, removeDumpHeapStats(), setkLimto 1 GiB inLimitRespected(keeping all other test limits unchanged), and addshard_count = 11.This reduces max shard execution time across all variants in
-c dbgfrom45.2sto2.60s(< 5.0s) with 0 flakes across 300 runs (100/100in-c dbg,-c fastbuild, and-c optunderblase --configs=none).