Always-inline CacheCpuSlab and avoid dirtying ResizeInfo::touched. - #818
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_981444438
branch
3 times, most recently
from
September 16, 2026 23:58
18ba54b to
7f48780
Compare
Marking CpuCache::CacheCpuSlab ABSL_ATTRIBUTE_ALWAYS_INLINE eliminates call/return overhead and allows the compiler to fold duplicate cached/cpu checks in AllocateSlowNoHooks and DeallocateSlowNoHooks. Guarding state.touched.store(true) with a relaxed load avoids dirtying the shared ResizeInfo cacheline on every slab recache when touched is already true. PiperOrigin-RevId: 981444438
copybara-service
Bot
force-pushed
the
test_981444438
branch
from
September 17, 2026 02:43
7f48780 to
8ac9381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always-inline CacheCpuSlab and avoid dirtying ResizeInfo::touched.
Marking CpuCache::CacheCpuSlab ABSL_ATTRIBUTE_ALWAYS_INLINE eliminates call/return overhead and allows the compiler to fold duplicate cached/cpu checks in AllocateSlowNoHooks and DeallocateSlowNoHooks. Guarding state.touched.store(true) with a relaxed load avoids dirtying the shared ResizeInfo cacheline on every slab recache when touched is already true.