Implement proper bulk loads in the transaction manager - #3233
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private static class CompoundId implements Serializable { | ||
| private static class CompoundId extends ImmutableObject implements Serializable { |
| } | ||
|
|
||
| private static class NamedCompoundId implements Serializable { | ||
| private static class NamedCompoundId extends ImmutableObject implements Serializable { |
weiminyu
approved these changes
Sep 21, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on gbrodman).
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 21, 2026
Previously we just looped over and loaded each entity one by one. It's better to try to limit it to fewer queries (ideally one). Fortunately, Hibernate supports bulk load of entities with both compound and simple IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we just looped over and loaded each entity one by one. It's better to try to limit it to fewer queries (ideally one). Fortunately, Hibernate supports bulk load of entities with both compound and simple IDs.
This change is