fix(a2a): preserve custom client factories - #6925
Open
gioboa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
RemoteA2aAgentrebuilt a caller-providedA2AClientFactorysubclass as the base factory when creating its HTTP client. This discarded overridden behaviour such as a customcreate()implementation.Solution:
Only rebuild the standard
A2AClientFactory. Preserve subclasses so their custom client creation behavior remains active.Testing Plan
Unit Tests:
The regression test provides a factory subclass with an overridden
create()method and verifies that it creates the remote client.Manual End-to-End (E2E) Tests:
RemoteA2aAgentthrough a realRunner.Checklist