fix: coerce callable AgentInfo.instruction for app-info - #6913
Open
a2105z wants to merge 1 commit into
Open
Conversation
GET /apps/{app_name}/app-info assigned LlmAgent.instruction onto
AgentInfo.instruction (typed str). InstructionProvider callables
raised ValidationError. Coerce to a placeholder; do not resolve
providers (they can be async and need session state).
Fixes google#6909
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /apps/{app_name}/app-infobuiltAgentInfowithinstruction=current_agent.instruction. That field is typedstr, butLlmAgent.instructionisstr | InstructionProvider. A callable raised an unhandledpydantic.ValidationError(500).<InstructionProvider: {name}>) in abeforevalidator. Do not resolve the provider: it may be async and may need session state.__name__) use the type name.Fixes #6909
Test plan
get_agents_dicton an agent withinstruction=dynamic_instructionraisesValidationError: Input should be a valid string(input_type=function) atagent_info.py_traverse/AgentInfo(...).uv run pytest tests/unittests/utils/test_agent_info.py— 13 passed<InstructionProvider: dynamic_instruction>(provider is not invoked)<InstructionProvider: Persona>@itaieban this is done —
app-infonow serializes callable instructions instead of 500ing.Made with Cursor