Skip to content

fix(mcp): reject config-supplied stdio MCP servers by default #6547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yusmer96-maker wants to merge 9 commits into
base: main
Choose a base branch
from
+6 −1
Open

fix(mcp): reject config-supplied stdio MCP servers by default #6547

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a35284e
fix(mcp): reject config-supplied stdio MCP servers by default
yusmer96-maker Aug 1, 2026
12f75d2
test(mcp): cover config-supplied stdio MCP server rejection
yusmer96-maker Aug 1, 2026
b36acec
Merge branch 'main' into fix/mcp-stdio-from-config
yusmer96-maker Aug 5, 2026
ef4bd2d
Merge branch 'main' into fix/mcp-stdio-from-config
yusmer96-maker Aug 7, 2026
5c792cd
Merge branch 'main' into fix/mcp-stdio-from-config
yusmer96-maker Aug 7, 2026
918cf69
Merge branch 'main' into fix/mcp-stdio-from-config
yusmer96-maker Aug 8, 2026
7600a69
Merge branch 'main' into fix/mcp-stdio-from-config
yusmer96-maker Aug 15, 2026
04a5934
Merge branch 'main' into fix/mcp-stdio-from-config
yusmer96-maker Aug 18, 2026
8de06fd
Merge branch 'main' into fix/mcp-stdio-from-config
yusmer96-maker Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/unittests/tools/mcp_tool/test_mcp_toolset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
from google.adk.tools.mcp_tool.mcp_session_manager import StdioConnectionParams
from google.adk.tools.mcp_tool.mcp_session_manager import StreamableHTTPConnectionParams
from google.adk.tools.mcp_tool.mcp_tool import MCPTool
from google.adk.tools.mcp_tool.mcp_toolset import _set_allow_config_stdio_servers
from google.adk.tools.mcp_tool.mcp_toolset import McpToolset
from google.adk.tools.mcp_tool.mcp_toolset import McpToolsetConfig
from google.adk.tools.tool_configs import ToolArgsConfig
Expand Down Expand Up @@ -269,7 +270,11 @@ def test_from_config_with_credential_key(self):
auth_scheme=auth_scheme,
credential_key="my_custom_key",
)
toolset = McpToolset.from_config(config, "")
_set_allow_config_stdio_servers(True)
try:
toolset = McpToolset.from_config(config, "")
finally:
_set_allow_config_stdio_servers(False)

assert isinstance(toolset._auth_scheme, OAuth2)
assert toolset._auth_config.credential_key == "my_custom_key"
Expand Down