Repository navigation
fix: cover langchain 0.1.87, llama-index 4.7.7 and anthropic 3.3.6 in the newest-instrumentor checks - #294
Merged
Conversation
… the newest-instrumentor checks OpenInference released langchain 0.1.87, llama-index 4.7.7 and anthropic 3.3.6 on 2026-11-16 at 23:47Z, and the scheduled newest-instrumentors run went red. langchain 0.1.87 only adds a retriever document id. Widened the LangChain stopgap to it. llama-index 4.7.7 runs each step of a streamed LLM call with its span current by itself, so the LlamaIndex stopgap stays out from there and its range keeps ending at 4.7.6. The tests of how it installs skip on releases past it. anthropic 3.3.6 writes each tool's name and description as llm.tools.N.tool.name and .description beside the schema. They are copies of the schema, so they now leave with it when the definitions are reassembled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled
newest-instrumentorsrun went red on 2026-11-17 (run 44021844284). The push run at 23:10Z on 2026-11-16 passed. OpenInference then released three instrumentors at 23:47Z: langchain 0.1.87, llama-index 4.7.7 and anthropic 3.3.6. The same job fails on #292.The failing run stopped at the stopgap step, with 16 failures: 9 in LangChain ("the provider span has no parent",
install()returned False) and 7 in LlamaIndex (install()returned False). The anthropic step never ran. Run locally, it fails too, on the tool-definition check.What changed upstream (compared from the wheels)
_tracer.pyadds a retriever document'sidasdocument.id. Same dependency floors. The stopgap uses none of it:_tracer.get_span()and the hookedlangchain-coremethods are unchanged. Widened to 0.1.87._llm_stream.pywrapsstream_chat,stream_complete,astream_chatandastream_completeon everyBaseLLMandMultiModalLLMsubclass, including ones defined later. Each step of the stream runs with the LLM span current. The span handler now hands that span over throughpop_llm_stream_span. This is the stopgap's job, done upstream. So, like the LiteLLM stopgap from 0.1.51, the LlamaIndex stopgap stays out from 4.7.7 and its range still ends at 4.7.6. In the failing run, every end-to-end nesting and counts-once test already passed on 4.7.7 with the stopgap not installed._get_llm_toolsnow writesllm.tools.N.tool.nameandllm.tools.N.tool.descriptionnext tollm.tools.N.tool.json_schema. They are copies of fields in the schema. We reassembled the schemas intogen_ai.tool.definitionsbut left the copies on the span. They are content by prefix, socapture_content=Falsestill strips them and nothing escaped. They were duplicates, though.Changes
langchain_span_context.VERIFIED_VERSIONSnow ends at 0.1.87.llama_index_span_context: the range is unchanged, with a comment explaining why it stops at 4.7.6. In the tests, the six that need the stopgap installed (subclass hook, re-init, install twice, handler order, uninstall, busy handler) are marked@installs. That skips them past the verified range, the same way the LiteLLM re-init test does.test_an_unverified_version_installs_nothingnow takes its baseline afterinstrument(), because 4.7.7 wraps the stream methods itself.normalize_tool_definitionsdropsllm.tools.N.tool.nameand.descriptionfor each index whose schema it reassembled. A name at an index with no schema is left alone. When any schema fails to parse, the whole family is still left untouched. There are three new tests intests/test_normalization_tools.py.Verification
ruff check,ruff format --checkandmypyare clean.pytest: 3129 passed, 22 skipped, 1 xfailed.uv lock --upgrade-package …step asnewest-instrumentors(OI langchain 0.1.87, OI llama-index 4.7.7, OI litellm 0.1.58, OI anthropic 3.3.6, anthropic 2.9.0, langchain-core 1.8.1, langchain-openai 1.8.0, litellm 1.109.1, llama-index-core 0.14.26, llama-index-llms-openai 0.9.0):@installstests and the LiteLLM re-init test)uv.lockis unchanged, as in #257, #268 and #282. Dependabot handles the bumps.