Skip to content

Remove the generated title when no-title is added after render #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwy404 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove the generated title when no-title is added after render #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/relative-time-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,11 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor
const hourCycle = this.hourCycle
if (!this.#customTitle) {
newTitle = this.#getFormattedTitle(date, locale, timeZone, hourCycle) || ''
if (newTitle && !this.noTitle && newTitle !== oldTitle) this.setAttribute('title', newTitle)
if (this.noTitle) {
this.removeAttribute('title')
} else if (newTitle && newTitle !== oldTitle) {
this.setAttribute('title', newTitle)
}
}

const duration = elapsedTime(date, this.precision, now)
Expand Down
32 changes: 32 additions & 0 deletions test/relative-time.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,38 @@ suite('relative-time', function () {
assert.equal(el.getAttribute('title'), null)
})

test('removes the title when no-title is added after rendering', async () => {
const el = document.createElement('relative-time')
el.setAttribute('datetime', new Date().toISOString())
await Promise.resolve()
assert.ok(el.getAttribute('title'))
el.setAttribute('no-title', '')
await Promise.resolve()
assert.equal(el.getAttribute('title'), null)
})

test('keeps a custom title when no-title is added', async () => {
const el = document.createElement('relative-time')
el.setAttribute('datetime', new Date().toISOString())
el.setAttribute('title', 'custom')
await Promise.resolve()
el.setAttribute('no-title', '')
await Promise.resolve()
assert.equal(el.getAttribute('title'), 'custom')
})

test('sets the title again when no-title is removed', async () => {
const el = document.createElement('relative-time')
el.setAttribute('datetime', new Date().toISOString())
await Promise.resolve()
const title = el.getAttribute('title')
el.setAttribute('no-title', '')
await Promise.resolve()
el.removeAttribute('no-title')
await Promise.resolve()
assert.equal(el.getAttribute('title'), title)
})

test('shadowDOM reflects textContent with invalid date', async () => {
const el = document.createElement('relative-time')
el.textContent = 'A date string'
Expand Down