Skip to content

ci: update Playwright for Ubuntu 26.04 support - #394

Merged
liuliu-dev merged 2 commits into
mainfrom
agents/can-you-fix-this-workflow-run-in-a
Nov 4, 2026
Merged

liuliu-dev merged 2 commits into
mainfrom
agents/can-you-fix-this-workflow-run-in-a

Conversation

@liuliu-dev

@liuliu-dev liuliu-dev commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

what changed

  • add Playwright ^1.64.1 as an explicit dev dependency and update the lockfile
  • keep all workflows on ubuntu-latest; no runner pins remain in the final diff
  • the CLI browser installation and @web/test-runner-playwright share Playwright 1.64.1

why

The failed job on #390 stops before tests run: ubuntu-latest resolves to Ubuntu 26.04, which the previously locked Playwright 1.58.2 does not support. Playwright 1.64.1 supports Ubuntu 26.04, fixing this without an Ubuntu pin that would need a later cleanup.

This is a standalone fix against main; it does not include the changes from #390. Once merged, #390 will need to pick it up to fix its checks.

validation

  • git diff --check
  • npx playwright install chromium
  • npm test — build, type-check, lint, and all 638 browser tests pass locally on macOS
  • npm ls confirms the CLI and test runner share Playwright 1.64.1
  • PR CI validates browser dependency installation and tests on ubuntu-latest

Avoid Ubuntu 26.04 from ubuntu-latest, which the installed Playwright version does not support.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@liuliu-dev
liuliu-dev requested a review from a team as a code owner November 4, 2026 19:16
Copilot AI auto review requested due to automatic review settings November 4, 2026 19:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified in the supplied evidence, and the runner changes are documented with their Playwright compatibility rationale.

No open issues 🎉

What changed in this PR

This pull request pins the Playwright-related CI and publishing jobs to Ubuntu 24.04 to avoid incompatibility with newer Ubuntu images.

Changes:

  • Pins the Node CI job to ubuntu-24.04.
  • Pins both publishing jobs to ubuntu-24.04.
  • Documents the Playwright compatibility rationale beside each runner setting.

This pull request is ready to be approved.

File Description
.github/​workflows/​test.yml Pins the Node CI job to Ubuntu 24.04 for Playwright compatibility.
.github/​workflows/​publish.yml Pins both publishing jobs to Ubuntu 24.04 and documents the compatibility reason.

Review effort: Lite (auto)

Declare Playwright explicitly so browser installation and the test runner use a version supporting Ubuntu 26.04, while keeping ubuntu-latest.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@liuliu-dev liuliu-dev changed the title ci: pin Playwright workflows to Ubuntu 24.04 ci: update Playwright for Ubuntu 26.04 support Nov 4, 2026
@liuliu-dev
liuliu-dev merged commit 1e53c6a into main Nov 4, 2026
6 checks passed
@liuliu-dev
liuliu-dev deleted the agents/can-you-fix-this-workflow-run-in-a branch November 4, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants