fix(insights): Repair legacy /performance/<module>/ redirects - #122407
Open
mrduncan wants to merge 1 commit into
Open
fix(insights): Repair legacy /performance/<module>/ redirects#122407mrduncan wants to merge 1 commit into
/performance/<module>/ redirects#122407mrduncan wants to merge 1 commit into
Conversation
Legacy `/performance/<module>/*` URLs redirected to a broken target that 404'd: `/performance/database/` sent users to `/insights/backenddatabase/:splat`. Two problems combined into that URL: - The domain view and module base URL were joined without a separator, producing `backenddatabase` instead of `backend/database`. Introduced when the domain view segment was added to the redirect target. - `:splat` was never substituted. It was a react-router 3 param name; react-router 6 exposes the wildcard match as `*`, and a `redirectTo` string is handed to `Navigate` verbatim, so nothing ever replaced it. Rather than teach the redirect machinery to interpolate wildcards, the target is now the module landing page. Sub-paths under a legacy module URL land there instead of at their equivalent sub-path, which they have never reached anyway.
github-actions
Bot
added
the
Scope: Frontend
mrduncan
marked this pull request as ready for review
August 21, 2026 17:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy
/performance/<module>/*URLs redirected to a broken target that 404'd:/performance/database/sent users to/insights/backenddatabase/:splat.Two problems combined into that URL:
backenddatabaseinstead ofbackend/database. Introduced when the domain view segment was added to the redirect target.:splatwas never substituted. It was a react-router 3 param name; react-router 6 exposes the wildcard match as*, and aredirectTostring is handed toNavigateverbatim, so nothing ever replaced it.This opts for a simple fix to target module landing pages rather than build out wildcard interpolation.
Example replay (error at 2s): https://sentry.sentry.io/explore/replays/8cb8dbb5091f452d9c701838f5317e07/