test(ios): Speed up sentry-xcode-scripts tests - #6633
Open
antonis wants to merge 1 commit into
Open
Conversation
Four upload-behavior tests in the sentry-xcode-debug-files.sh block never create a dSYM bundle and did not disable the dSYM wait, so each fell into wait_for_dsym_files() and waited out the full ~10s default timeout. They assert only on upload output, so disable the wait with SENTRY_DSYM_WAIT_ENABLED=false. The dedicated 'dSYM wait functionality' block still covers the wait behavior. Cuts the file from ~59s to ~15s with no change in coverage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7571b73. Configure here.
antonis
marked this pull request as ready for review
August 28, 2026 13:06
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Four upload-behavior tests in the
sentry-xcode-debug-files.shblock ofsentry-xcode-scripts.test.tsnever create a dSYM bundle and did not disable the dSYM wait. As a result each one fell intowait_for_dsym_files()and waited out the full default timeout (10 attempts with progressive backoff ≈ 10s) for a dSYM that is never produced. The tests passed anyway — the script proceeds after the timeout — so the cost was invisible, just slow.Since these tests assert only on upload success/error output, this sets
SENTRY_DSYM_WAIT_ENABLED=falseon those four tests. The dedicateddSYM wait functionalityblock still exercises the wait behavior and is unchanged.No change in coverage.
💡 Motivation and Context
test/scripts/sentry-xcode-scripts.test.tstook ~59s while every other test file finishes in seconds. The four affected tests accounted for ~44s of that (~11s each), all spent sleeping in the dSYM wait loop rather than testing anything.Verified at the script level: invoking
sentry-xcode-debug-files.shwith the exact env these tests use runs for 10.835s with the wait enabled vs 0.048s withSENTRY_DSYM_WAIT_ENABLED=false.💚 How did you test it?
Ran the file before and after:
Time: 59.148 s, 40 passedTime: 14.74 s, 40 passedThe remaining time is legitimate — the dedicated wait tests intentionally sleep 1–2s and assert on real timing.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
🤖 Generated with Claude Code