-
-
Notifications
You must be signed in to change notification settings - Fork 365
chore(deps): update React Native to v0.87.1 #6607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
github-actions
wants to merge
1
commit into
main
Choose a base branch
from
deps/scripts/update-rn.sh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+327
−151
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Native 0.87.1 is paired with incompatible 0.86.2 Metro tooling
Upgrade the explicitly declared
@react-native/metro-configpackages alongside React Native. React Native 0.87.1 brings@react-native/community-cli-plugin@0.87.1, whose optional peer requires@react-native/metro-config@0.87.1, while the core package and sample apps still install@react-native/metro-config@0.86.2. This can leavereact-native startand Metro CLI integration running with an incompatible configuration package. The sample apps also retain@react-native/new-app-screen@0.86.2, whose peer dependency requires React Native exactly0.86.2.Evidence
react-native@0.87.1depends on@react-native/community-cli-plugin@0.87.1inyarn.lock.@react-native/community-cli-plugin@0.87.1declares@react-native/metro-config: 0.87.1, but no 0.87.x Metro config exists in the lockfile.packages/core,samples/react-native, and both performance apps explicitly resolve@react-native/metro-config@0.86.2and use it in their Metro configuration or SDK tooling.samples/react-nativeandperformance-tests/TestAppSentryretain@react-native/new-app-screen@0.86.2, whose lockfile peer requiresreact-native: 0.86.2.Also found at 1 additional location
samples/react-native/package.json:56-56Identified by Warden · code-review, find-bugs · TBY-FGC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix attempt detected (commit 8be6162)
The commit upgrades React Native to 0.87.1 and refreshes the lockfile, but leaves the explicitly declared @react-native/metro-config and @react-native/new-app-screen dependencies at 0.86.2 in the sample and performance apps, so the incompatibility persists.
The original issue appears unresolved. Please review and try again.
Evaluated by Warden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix attempt detected (commit e98296d)
The commit upgraded React Native to 0.87.1 and refreshed related lockfile tooling, but the sample and performance apps still explicitly use @react-native/metro-config@0.86.2 and @react-native/new-app-screen@0.86.2, so the incompatibility remains.
The original issue appears unresolved. Please review and try again.
Evaluated by Warden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix attempt detected (commit fdea9eb)
The commit upgrades React Native to 0.87.1 and its lockfile entries, but leaves @react-native/metro-config@0.86.2 in the sample and performance app manifests and retains @react-native/new-app-screen@0.86.2, so the incompatibility persists.
The original issue appears unresolved. Please review and try again.
Evaluated by Warden