Skip to content

ci: Add aiohttp to uv typing group - #7395

Open
alexander-alderman-webb wants to merge 1 commit into
webb/tiktoken-typesfrom
webb/aiohttp-types
Open

ci: Add aiohttp to uv typing group#7395
alexander-alderman-webb wants to merge 1 commit into
webb/tiktoken-typesfrom
webb/aiohttp-types

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Add aiohttp to the typing dependency group and fix the resulting mypy errors.

Resolve

sentry_sdk/integrations/aiohttp.py:313: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/aiohttp.py:353: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/aiohttp.py:366: error: Cannot assign to a method  [method-assign]

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 4, 2026 14:52
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

130172 passed | ❌ 2 failed | ⏭️ 7110 skipped | Total: 137284 | Pass Rate: 94.82% | Execution Time: 465m 56s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -422
Passed Tests 📉 -423
Failed Tests 📈 +1
Skipped Tests

➕ New Tests (1)

View new tests
  • test_db_transaction_spans_disabled_atomic[True]
    • File: tests.integrations.django.test_db_transactions
    • Status: ❌ Failing

❌ Failed Tests

test_db_transaction_spans_disabled_atomic[True]

File: tests.integrations.django.test_db_transactions
Suite: py3.14t-django-v5.2.17
Error: tests/integrations/django/test_db_transactions.py:384: in test_db_transaction_spans_disabled_atomic assert postgres_commit["is_segment"] is True E assert False is True

Stack Trace
tests/integrations/django/test_db_transactions.py:384: in test_db_transaction_spans_disabled_atomic
    assert postgres_commit["is_segment"] is True
E   assert False is True

test_segment_uses_downsampled_rate

File: tests.test_monitor
Suite: py3.6-common
Error: assert 0.25 == 0.5 +0.25 -0.5

Stack Trace
tests/test_monitor.py:116: in test_segment_uses_downsampled_rate
    assert segment._sample_rate == 0.5
E   assert 0.25 == 0.5
E     +0.25
E     -0.5

✅ Patch coverage is 100.00%. Project has 2503 uncovered lines.
✅ Project coverage is 90.27%. Comparing base (b71a773) to head (98f1130).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.27%    90.27%        —%
==========================================
  Files          193       193         —
  Lines        25724     25724         —
  Branches      9504      9504         —
==========================================
+ Hits         23222     23221        -1
- Misses        2502      2503        +1
- Partials      1433      1434        +1

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant