fix(mcp): Handle None arguments in tool and prompt handlers - #7387
Open
alexander-alderman-webb wants to merge 1 commit into
Open
Conversation
Contributor
Codecov Results 📊✅ 130596 passed | ⏭️ 7110 skipped | Total: 137706 | Pass Rate: 94.84% | Execution Time: 466m 25s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2509 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
+ Coverage 90.24% 90.24% —%
==========================================
Files 193 193 —
Lines 25724 25713 -11
Branches 9504 9494 -10
==========================================
+ Hits 23214 23204 -10
- Misses 2510 2509 -1
- Partials 1435 1432 -3Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just following the types,
argumentscan beNone. For example:https://github.com/modelcontextprotocol/python-sdk/blob/d060b36e1d095ef6e93e07ba5d59bb69b2ad449a/src/mcp-types/mcp_types/_types.py#L1449-L1453
The prompt case is recorded in the reported issue.
Issues
Closes #7374
Reminders
uv run ruff.feat:,fix:,ref:,meta:)