Skip to content

ref(mcp): Inline _extract_handler_data_from_args() - #7386

Open
alexander-alderman-webb wants to merge 2 commits into
masterfrom
webb/mcp/inline-extract_handler_data_from_args
Open

ref(mcp): Inline _extract_handler_data_from_args()#7386
alexander-alderman-webb wants to merge 2 commits into
masterfrom
webb/mcp/inline-extract_handler_data_from_args

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Remove unnecessary indirection.

Issues

Reminders

Comment thread sentry_sdk/integrations/mcp.py
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

129901 passed | ❌ 1 failed | ⏭️ 7110 skipped | Total: 137012 | Pass Rate: 94.81% | Execution Time: 469m 16s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -694
Passed Tests 📉 -695
Failed Tests 📈 +1
Skipped Tests

➕ New Tests (1)

View new tests
  • test_cache_spans_item_size[True]
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_cache_spans_item_size[True]

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v6.1
Error: tests/integrations/django/test_cache_module.py:764: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:764: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

❌ Patch coverage is 62.96%. Project has 2509 uncovered lines.
✅ Project coverage is 90.24%. Comparing base (692cca2) to head (885ac3b).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/mcp.py 62.96% ⚠️ 10 Missing and 5 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.24%    90.24%        —%
==========================================
  Files          193       193         —
  Lines        25724     25713       -11
  Branches      9504      9494       -10
==========================================
+ Hits         23214     23204       -10
- Misses        2510      2509        -1
- Partials      1435      1432        -3

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 4, 2026 12:54
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 4, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant