fix(remix): Prefer narrower routes over splats when both match - #23567
Open
chargome wants to merge 1 commit into
Open
fix(remix): Prefer narrower routes over splats when both match#23567chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
Route specificity summed per-segment scores, so a short splat like '/:lang/:*' outranked a longer but strictly narrower route like '/:lang/guides/:category/:*'. Transactions for those paths were reported under the splat route. Compare segment by segment instead, with the first differing segment deciding. Rank the end of a route between a dynamic segment and a splat, so that continuing into a static or dynamic segment narrows a route while continuing into a splat widens it. Mirrors the same fix in @sentry/nextjs. Refs #23488 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7d7dc1f. Configure here.
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
August 25, 2026 08:59
chargome
requested review from
logaretm,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team and
mydea
August 25, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route specificity summed per-segment scores, so a short splat (
/:lang/:*) outranked alonger but strictly narrower route (
/:lang/guides/:category/:*). Transactions for thosepaths were reported under the splat route.
Specificity is now compared segment by segment, with the end of a route ranked between a
dynamic segment and a splat.
Follow-up to #23520, which fixes the same flaw in
@sentry/nextjs.Refs #23488