feat(browser): Emit low cardinality resource span names - #23546
Merged
Conversation
logaretm
force-pushed
the
awad/resource-span-names
branch
from
August 24, 2026 17:45
6b1501e to
6d54bef
Compare
logaretm
marked this pull request as ready for review
August 24, 2026 17:50
logaretm
requested review from
Lms24 and
msonnb
and removed request for
a team
August 24, 2026 17:51
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/resource-span-names
branch
from
August 24, 2026 18:26
6d54bef to
cdc1a65
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cdc1a65. Configure here.
Lms24
approved these changes
Aug 25, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
changes LGTM! I had some comments around the migration guide, most of which touch more than your PR surface. Feel free to go with a more concise version than what I suggested. I should have worded these more carefully before merging the initial version of this guide.
logaretm
force-pushed
the
awad/resource-span-names
branch
from
August 25, 2026 14:06
7ba8c5e to
74323f2
Compare
Names `resource.*` spans after the resource domain when span streaming is enabled, falling back to `Resource` when there is none. Also adds the `url.domain` attribute to these spans.
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
logaretm
force-pushed
the
awad/resource-span-names
branch
from
August 25, 2026 14:52
74323f2 to
73093f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names
resource.*spans after the resource domain when span streaming is enabled, falling back toResourcewhen there's no domain.The domain also lands on the span as
url.domainin both lifecycles since it's just a missing attribute. Names in static mode are unchanged.closes #23531