fix: keep interleaved query parameter values - #820
Open
nickita-khylkouski wants to merge 1 commit into
Open
nickita-khylkouski wants to merge 1 commit into
nickita-khylkouski wants to merge 1 commit into
Conversation
nickita-khylkouski
force-pushed
the
fix/interleaved-query-params
branch
from
September 15, 2026 20:34
6bd3382 to
bcf3d94
Compare
markstory
reviewed
Sep 16, 2026
| ), | ||
| ], | ||
| ) | ||
| def test_request_param_with_interleaved_keys(params, expected): # type: ignore[misc] |
Member
There was a problem hiding this comment.
I know there are some existing tests with ignores. Can we remove the type: ignore on this one so that I don't have more to clean up later?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
==========================================
+ Coverage 99.84% 99.91% +0.06%
==========================================
Files 9 9
Lines 3295 3370 +75
==========================================
+ Hits 3290 3367 +77
+ Misses 5 3 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Replace the adjacency-dependent
groupby(parse_qsl(...))logic withparse_qs(...).items(). Repeated values are now retained even when another query key appears between them.Related Issues
None.
PR checklist
Before submitting this pull request, I have done the following:
toxandpre-commitchecks locallyI ran the complete pytest suite (236 passed), all pre-commit hooks, and a package build. Current mypy reports the same three pre-existing errors on an unchanged upstream checkout.
Added/updated tests?