Remove nested disclosure from command timeline details - #3156
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Remove nested disclosure from command timeline details#3156bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The expanded timeline body mounted a second command disclosure with its own state initialized to collapsed, so opening the row left the command under a separate two-line clamp. The independent reproduction and root-cause report is https://get-bb.github.io/reports/issues/3152.html.
What changed
The command detail is now a non-interactive fully visible block inside the already-expanded row. It retains the existing maximum-height overflow behavior for exceptionally long commands. A focused React regression covers the outer-row interaction and verifies that the command has no nested disclosure or clamp.
How you verified
aria-expanded="false"and-webkit-line-clamp: 2.pnpm exec turbo run test typecheck lint --filter=@bb/apppassed: 481 test files, 3,923 passing tests, 4 skipped, and all 6 Turbo tasks successful.git diff --check origin/mainpassed.Fixes #3152