Reject duplicate content in restored split layouts - #3064
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Reject duplicate content in restored split layouts#3064bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The restored split-layout boundary accepted unique pane IDs even when multiple panes carried the same logical content. The split renderer then mounted a complete thread view for every accepted node, duplicating all thread-owned chrome. The direct reproduction and root-cause report is https://get-bb.github.io/reports/issues/3062.html.
What changed
The split-layout parser now rejects duplicate logical pane content using the same identity rules as live pane navigation. Invalid restored state falls back to the current route's single pane. This changes no wire protocol, public API, dependency, migration, or stored-data format.
How you verified
expected length 1, received 4while 48 tests passed.pnpm exec turbo run typecheck --filter=@bb/apppassed.git diff --checkpassed.Fixes #3062