feat(mapbox): upgrade Mapbox provider to Geocoding API v6 (2.0.0) - #1274
Open
davidbarratt wants to merge 13 commits into
Open
feat(mapbox): upgrade Mapbox provider to Geocoding API v6 (2.0.0) #1274davidbarratt wants to merge 13 commits into
davidbarratt wants to merge 13 commits into
Conversation
Author
|
@jbelien I've run the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Geocoder\Provider\Mapbox\Mapboxin place to the Mapbox Geocoding API v6 (/search/geocode/v6/forwardand/search/geocode/v6/reverse), as a major version (2.0.0) ofgeocoder-php/mapbox-providerautocomplete/proximity/worldviewquery data, a new 4th constructor argumentbool $permanent,TYPE_STREET/TYPE_BLOCK/TYPE_SECONDARY_ADDRESSconstants, andMapboxAddress::getMatchCode()/getMatchConfidence()/getAccuracy()GEOCODING_MODE_*,TYPE_POI*andfuzzy_match; every breaking change is listed in the provider CHANGELOG 2.0.0 (v5 users: pin togeocoder-php/mapbox-provider:^1.5)Closes #1237
Test Plan
composer test— full suite green (1049 tests); Mapbox: 45 tests incl. 7 v6 integration fixtures + 4 provider-integration fixtures replayed from.cached_responseswith the placeholder key (CI-safe)composer analyse— PHPStan level 6 cleancomposer cs— clean on all touched filestest(mapbox): add failing tests for the v6 API) is followed by the implementation commits that turn the suite green