Simplify result verification: t+1 only for keygen

.gitignore

@@ -24,4 +24,5 @@ node2
 config.yaml
 .vscode
 .vagrant
-.chain_code
+.chain_code
+node_public_keys.json

README.md

@@ -318,6 +318,27 @@ configs := []client.KMSSignerOptions{
 
 **Note**: AWS KMS only supports P256 (ECDSA) keys, not Ed25519. If you need Ed25519, use the local signer.
 
+#### Verifying node-signed results
+
+Each node signs the results it publishes with its identity key, in the `Mpc-Node-Id` and `Mpc-Result-Sig` NATS headers. The message body is unchanged. A client pins the node public keys and checks every result before using it:
+
+```go
+mpcClient := client.NewMPCClient(client.Options{
+    NatsConn:                     natsConn,
+    Signer:                       localSigner,
+    ResultVerifyMode:             client.ResultVerifyEnforce, // off (default) | log | enforce
+    NodePublicKeys:               nodePublicKeys,             // node_id -> hex public key
+    KeygenRequiredNodeSignatures: 3,                          // mpc_threshold + 1
+})
+```
+
+- `setup_identities.sh` writes `node_public_keys.json` for new local setups. For an existing setup or a production cluster, run `mpcium-cli export-node-keys --identity-dir <dir>` against any node's identity directory, which holds every node's `*_identity.json`.
+- `enforce` rejects unsigned or tampered results. `log` reports failed checks but still delivers every result; use it while rolling out.
+- A single compromised node can still sign a false result. Signing and reshare results can be checked against keys the caller already has: verify signatures with `client.VerifySigningResult` against the wallet (or derived child) public key, and check that a reshare kept the wallet public key unchanged.
+- A new wallet public key cannot be checked that way, so `KeygenRequiredNodeSignatures` makes the client wait until that many nodes report the same key. The client asks the nodes for one copy each on its keygen requests; no node config is needed, but the nodes must run a version that understands the request.
+- With `KeygenRequiredNodeSignatures` above 1, give each client process its own `ClientID`. Processes that share one also share a JetStream consumer, which splits the node copies of a result between them, so none may reach the required count.
+- JetStream delivers at least once, so handle a result for the same `TxID`, wallet or reshare session idempotently.
+
 ## Test with AWS KMS (LocalStack)
 
 For local development and testing with AWS KMS functionality, you can use LocalStack to simulate AWS KMS services.

cmd/mpcium-cli/export-node-keys.go

@@ -0,0 +1,84 @@
+package main
+
+import (
+	"context"
+	"encoding/json"
+	"errors"
+	"fmt"
+	"os"
+	"slices"
+
+	"github.com/fystack/mpcium/pkg/resultauth"
+	"github.com/urfave/cli/v3"
+)
+
+func exportNodeKeys(ctx context.Context, c *cli.Command) error {
+	publicKeys := make(map[string]string)
+	for _, identityDir := range c.StringSlice("identity-dir") {
+		dirKeys, err := resultauth.LoadPublicKeys(identityDir)
+		if err != nil {
+			return err
+		}
+		for nodeID, publicKey := range dirKeys {
+			if existing, ok := publicKeys[nodeID]; ok && existing != publicKey {
+				return fmt.Errorf("node %s has different public keys in the identity directories", nodeID)
+			}
+			publicKeys[nodeID] = publicKey
+		}
+	}
+	if len(publicKeys) == 0 {
+		return fmt.Errorf("no *_identity.json files found in %v", c.StringSlice("identity-dir"))
+	}
+	if _, err := resultauth.NewKeyLookup(publicKeys); err != nil {
+		return err
+	}
+	if err := checkAllPeersHaveKeys(c.String("peers"), publicKeys); err != nil {
+		return err
+	}
+
+	data, err := json.MarshalIndent(publicKeys, "", "  ")
+	if err != nil {
+		return fmt.Errorf("failed to encode node public keys: %w", err)
+	}
+	data = append(data, '\n')
+
+	outputPath := c.String("output")
+	if outputPath == "-" {
+		_, err := os.Stdout.Write(data)
+		return err
+	}
+	if _, err := os.Stat(outputPath); err == nil && !c.Bool("overwrite") {
+		return fmt.Errorf("file %s already exists, use --overwrite to replace it", outputPath)
+	}
+	if err := os.WriteFile(outputPath, data, 0o600); err != nil {
+		return fmt.Errorf("failed to write %s: %w", outputPath, err)
+	}
+	fmt.Printf("Wrote %d node public keys to %s\n", len(publicKeys), outputPath)
+	return nil
+}
+
+func checkAllPeersHaveKeys(peersPath string, publicKeys map[string]string) error {
+	data, err := os.ReadFile(peersPath)
+	if errors.Is(err, os.ErrNotExist) {
+		return nil
+	}
+	if err != nil {
+		return fmt.Errorf("failed to read %s: %w", peersPath, err)
+	}
+	var peers map[string]string
+	if err := json.Unmarshal(data, &peers); err != nil {
+		return fmt.Errorf("failed to parse %s: %w", peersPath, err)
+	}
+
+	var missing []string
+	for name, nodeID := range peers {
+		if _, ok := publicKeys[nodeID]; !ok {
+			missing = append(missing, name)
+		}
+	}
+	if len(missing) > 0 {
+		slices.Sort(missing)
+		return fmt.Errorf("no identity file found for peers %v", missing)
+	}
+	return nil
+}

cmd/mpcium-cli/main.go

@@ -102,6 +102,36 @@ func main() {
 				},
 				Action: generateIdentity,
 			},
+			{
+				Name:  "export-node-keys",
+				Usage: "Write node_id -> public key JSON from node identity files, for clients that verify node-signed results",
+				Flags: []cli.Flag{
+					&cli.StringSliceFlag{
+						Name:    "identity-dir",
+						Aliases: []string{"i"},
+						Value:   []string{"identity"},
+						Usage:   "Directory with <node>_identity.json files; repeat for several directories",
+					},
+					&cli.StringFlag{
+						Name:    "peers",
+						Aliases: []string{"p"},
+						Value:   "peers.json",
+						Usage:   "peers.json used to check that every node has a key; skipped if the file does not exist",
+					},
+					&cli.StringFlag{
+						Name:    "output",
+						Aliases: []string{"o"},
+						Value:   "node_public_keys.json",
+						Usage:   "Output file, or - for stdout",
+					},
+					&cli.BoolFlag{
+						Name:    "overwrite",
+						Aliases: []string{"f"},
+						Usage:   "Overwrite the output file if it already exists",
+					},
+				},
+				Action: exportNodeKeys,
+			},
 			{
 				Name:  "generate-initiator",
 				Usage: "Generate identity files for an event initiator node",

cmd/mpcium/main.go

@@ -24,6 +24,7 @@ import (
 	"github.com/fystack/mpcium/pkg/logger"
 	"github.com/fystack/mpcium/pkg/messaging"
 	"github.com/fystack/mpcium/pkg/mpc"
+	"github.com/fystack/mpcium/pkg/resultauth"
 	"github.com/fystack/mpcium/pkg/security"
 	"github.com/hashicorp/consul/api"
 	"github.com/nats-io/nats.go"
@@ -225,11 +226,20 @@ func runNode(ctx context.Context, c *cli.Command) error {
 	directMessaging := messaging.NewNatsDirectMessaging(natsConn)
 	mqManager := messaging.NewNATsMessageQueueManager("mpc", event.ResultStreamSubjects(), natsConn)
 
-	genKeyResultQueue := mqManager.NewMessageQueue("mpc_keygen_result", event.KeygenResultSubscriptionSubject(""))
+	genKeyResultQueue := resultauth.NewSigningQueue(
+		mqManager.NewMessageQueue("mpc_keygen_result", event.KeygenResultSubscriptionSubject("")),
+		identityStore, nodeID,
+	)
 	defer genKeyResultQueue.Close()
-	singingResultQueue := mqManager.NewMessageQueue("mpc_signing_result", event.SigningResultSubscriptionSubject(""))
+	singingResultQueue := resultauth.NewSigningQueue(
+		mqManager.NewMessageQueue("mpc_signing_result", event.SigningResultSubscriptionSubject("")),
+		identityStore, nodeID,
+	)
 	defer singingResultQueue.Close()
-	reshareResultQueue := mqManager.NewMessageQueue("mpc_reshare_result", event.ReshareResultSubscriptionSubject(""))
+	reshareResultQueue := resultauth.NewSigningQueue(
+		mqManager.NewMessageQueue("mpc_reshare_result", event.ReshareResultSubscriptionSubject("")),
+		identityStore, nodeID,
+	)
 	defer reshareResultQueue.Close()
 
 	logger.Info("Starting mpcium node", "version", Version, "ID", nodeID, "name", nodeName)

deployments/ecs/ecs-instruction.md

@@ -137,6 +137,12 @@ identity/node0/
 └── node2_identity.json
 ```
 
+Collect the node public keys for MPC clients. Clients pin them to check that results were signed by these nodes. They are public keys, not secrets. For a deployment that is already running, run the same command against any node's identity directory, which holds every node's `*_identity.json`:
+
+```bash
+mpcium-cli export-node-keys --identity-dir identity/node0
+```
+
 ### Step 5: Generate Chain Code
 
 ```bash

deployments/kubernetes/k8s-instruction.md

@@ -200,6 +200,12 @@ identity/node0/
 └── node0_private.key.age      (encrypted private key)
 ```
 
+Collect the node public keys for MPC clients. Clients pin them to check that results were signed by these nodes. They are public keys, not secrets. For a deployment that is already running, run the same command against any node's identity directory, which holds every node's `*_identity.json`:
+
+```bash
+mpcium-cli export-node-keys --identity-dir identity/node0 --identity-dir identity/node1 --identity-dir identity/node2
+```
+
 ### Step 5: Prepare Secrets
 
 You'll need the following secrets for each node:

deployments/systemd/README.md

@@ -218,6 +218,12 @@ scp /opt/mpcium/identity/node0_identity.json root@<node2-ip>:/opt/mpcium/identit
 
 ⚠️ Never copy `*_private.key` / `*_private.key.age` to other nodes.
 
+Collect the node public keys for MPC clients. Clients pin them to check that results were signed by these nodes. They are public keys, not secrets. For a deployment that is already running, run the same command against any node's identity directory, which holds every node's `*_identity.json`:
+
+```bash
+cd /opt/mpcium && mpcium-cli export-node-keys
+```
+
 Before continuing, double-check on every node that:
 
 - `/opt/mpcium/peers.json` exists

e2e/base_test.go

@@ -18,6 +18,7 @@ import (
 	"github.com/fystack/mpcium/pkg/client"
 	"github.com/fystack/mpcium/pkg/event"
 	"github.com/fystack/mpcium/pkg/kvstore"
+	"github.com/fystack/mpcium/pkg/resultauth"
 	"github.com/fystack/mpcium/pkg/types"
 	"github.com/hashicorp/consul/api"
 	"github.com/nats-io/nats.go"
@@ -186,6 +187,17 @@ func (s *E2ETestSuite) setupClients(t *testing.T) {
 	t.Log("Clients setup completed")
 }
 
+// e2eKeygenRequiredNodeSignatures is mpc_threshold + 1 from config.test.yaml.template.
+const e2eKeygenRequiredNodeSignatures = 2
+
+func (s *E2ETestSuite) nodePublicKeys(t *testing.T) map[string]string {
+	t.Helper()
+	publicKeys, err := resultauth.LoadPublicKeys(filepath.Join(s.testDir, "test_node0", "identity"))
+	require.NoError(t, err, "Failed to load node public keys")
+	require.NotEmpty(t, publicKeys, "No node identity files found")
+	return publicKeys
+}
+
 func (s *E2ETestSuite) SetupMPCClient(t *testing.T) {
 	t.Log("Setting up MPC client...")
 
@@ -207,9 +219,12 @@ func (s *E2ETestSuite) SetupMPCClient(t *testing.T) {
 	}
 
 	mpcClient := client.NewMPCClient(client.Options{
-		NatsConn: s.natsConn,
-		Signer:   localSigner,
-		ClientID: "e2e-suite",
+		NatsConn:                     s.natsConn,
+		Signer:                       localSigner,
+		ClientID:                     "e2e-suite",
+		ResultVerifyMode:             client.ResultVerifyEnforce,
+		NodePublicKeys:               s.nodePublicKeys(t),
+		KeygenRequiredNodeSignatures: e2eKeygenRequiredNodeSignatures,
 	})
 	s.mpcClient = mpcClient
 	t.Log("MPC client created")

e2e/multi_client_routing_test.go

@@ -170,9 +170,12 @@ func newScopedMPCClient(t *testing.T, suite *E2ETestSuite, clientID string) (cli
 	require.NoError(t, err, "Failed to connect scoped client %s to NATS", clientID)
 
 	mpcClient := client.NewMPCClient(client.Options{
-		NatsConn: natsConn,
-		Signer:   signer,
-		ClientID: clientID,
+		NatsConn:                     natsConn,
+		Signer:                       signer,
+		ClientID:                     clientID,
+		ResultVerifyMode:             client.ResultVerifyEnforce,
+		NodePublicKeys:               suite.nodePublicKeys(t),
+		KeygenRequiredNodeSignatures: e2eKeygenRequiredNodeSignatures,
 	})
 
 	return mpcClient, natsConn

examples/authorizers/generate/main.go

@@ -13,6 +13,7 @@ import (
 	"syscall"
 	"time"
 
+	"github.com/fystack/mpcium/examples/internal/exampleclient"
 	"github.com/fystack/mpcium/pkg/client"
 	"github.com/fystack/mpcium/pkg/config"
 	"github.com/fystack/mpcium/pkg/event"
@@ -86,11 +87,11 @@ func main() {
 		authorizerSigners[authorizerID] = signer
 	}
 
-	mpcClient := client.NewMPCClient(client.Options{
+	mpcClient := client.NewMPCClient(exampleclient.WithResultVerification(client.Options{
 		NatsConn: natsConn,
 		Signer:   localSigner,
 		ClientID: *clientID,
-	})
+	}))
 
 	var walletStartTimes sync.Map
 	var walletIDs []string

examples/authorizers/sign/main.go

@@ -9,6 +9,7 @@ import (
 	"slices"
 	"syscall"
 
+	"github.com/fystack/mpcium/examples/internal/exampleclient"
 	"github.com/fystack/mpcium/pkg/client"
 	"github.com/fystack/mpcium/pkg/config"
 	"github.com/fystack/mpcium/pkg/event"
@@ -80,11 +81,11 @@ func main() {
 		authorizerSigners[authorizerID] = signer
 	}
 
-	mpcClient := client.NewMPCClient(client.Options{
+	mpcClient := client.NewMPCClient(exampleclient.WithResultVerification(client.Options{
 		NatsConn: natsConn,
 		Signer:   localSigner,
 		ClientID: *clientID,
-	})
+	}))
 
 	// Create a signing request with authorizers
 	txID := uuid.New().String()

examples/ckd/main.go

@@ -8,6 +8,7 @@ import (
 	"slices"
 	"syscall"
 
+	"github.com/fystack/mpcium/examples/internal/exampleclient"
 	"github.com/fystack/mpcium/pkg/client"
 	"github.com/fystack/mpcium/pkg/config"
 	"github.com/fystack/mpcium/pkg/event"
@@ -63,11 +64,11 @@ func main() {
 		logger.Fatal("Failed to create local signer", err)
 	}
 
-	mpcClient := client.NewMPCClient(client.Options{
+	mpcClient := client.NewMPCClient(exampleclient.WithResultVerification(client.Options{
 		NatsConn: natsConn,
 		Signer:   localSigner,
 		ClientID: *clientID,
-	})
+	}))
 
 	// 2) Once wallet exists, immediately fire a SignTransaction
 	txID := uuid.New().String()

examples/generate/kms/main.go

@@ -11,6 +11,7 @@ import (
 	"syscall"
 	"time"
 
+	"github.com/fystack/mpcium/examples/internal/exampleclient"
 	"github.com/fystack/mpcium/pkg/client"
 	"github.com/fystack/mpcium/pkg/config"
 	"github.com/fystack/mpcium/pkg/event"
@@ -62,11 +63,11 @@ func main() {
 	}
 	logger.Info("Public key", "key", pubKey)
 
-	mpcClient := client.NewMPCClient(client.Options{
+	mpcClient := client.NewMPCClient(exampleclient.WithResultVerification(client.Options{
 		NatsConn: natsConn,
 		Signer:   kmsSigner,
 		ClientID: *clientID,
-	})
+	}))
 
 	var walletStartTimes sync.Map
 	var walletIDs []string

examples/generate/main.go

@@ -12,6 +12,7 @@ import (
 	"syscall"
 	"time"
 
+	"github.com/fystack/mpcium/examples/internal/exampleclient"
 	"github.com/fystack/mpcium/pkg/client"
 	"github.com/fystack/mpcium/pkg/config"
 	"github.com/fystack/mpcium/pkg/event"
@@ -69,11 +70,11 @@ func main() {
 		logger.Fatal("Failed to create local signer", err)
 	}
 
-	mpcClient := client.NewMPCClient(client.Options{
+	mpcClient := client.NewMPCClient(exampleclient.WithResultVerification(client.Options{
 		NatsConn: natsConn,
 		Signer:   localSigner,
 		ClientID: *clientID,
-	})
+	}))
 
 	var walletStartTimes sync.Map
 	var walletIDs []string