Skip to content

[Dependencies] Updating Microsoft.Sbom.Targets (Software Bill Of Materials) to 4.1.12 - #412

Draft
dnyw4l3n13 wants to merge 2 commits into
mainfrom
depends/update-microsoft.sbom.targets/4.1.12
Draft

dnyw4l3n13 wants to merge 2 commits into
mainfrom
depends/update-microsoft.sbom.targets/4.1.12

Conversation

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Description

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Removed no-longer used code

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • I have added tests to cover my changes.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.
  • No user-controlled or step-output value is string-interpolated directly into a run:/script: body (workflow or composite action); pass it via step-level env: and reference $VAR (bash) or process.env.VAR (github-script) instead.

@dnyw4l3n13 dnyw4l3n13 added the auto-pr Pull request created automatically label Sep 19, 2026
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Orchestrator: assigned self, no linked issues to sync labels from, checked out branch depends/update-microsoft.sbom.targets/4.1.12 (up to date with origin, no rebase needed). Next: awaiting CI / outstanding work check.

The buildcheck step failed because the Serilog PackageReference was
missing build;buildTransitive in IncludeAssets, which the package
requires.

Prompt: Work on pull request #412 in funfair-tech/BuildBot.
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Fixed in 24beee4 - corrected Serilog PackageReference IncludeAssets (was missing build;buildTransitive), which was failing the buildcheck required check. Board set to Development.

@credfeto

Copy link
Copy Markdown
Member

Roslyn analyzer findings

Source Rule Level File Line Suppressed Message
DotNet IL2026 error src/BuildBot/Helpers/Endpoints.CloudFormation.cs 26 yes Using member 'Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.MapPost(IEndpointRouteBuilder, String, Delegate)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. This API may perform reflection on the supplied delegate and its parameters. These types may be trimmed if not directly referenced.
DotNet CA2000 error src/BuildBot/Helpers/ServerStartup.cs 127 yes Call System.IDisposable.Dispose on object created by 'CreateLogger()' before all references to it are out of scope
DotNet IL2026 error src/BuildBot/Helpers/Endpoints.Watchtower.cs 19 yes Using member 'Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.MapPost(IEndpointRouteBuilder, String, Delegate)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. This API may perform reflection on the supplied delegate and its parameters. These types may be trimmed if not directly referenced.
DotNet IL2026 error src/BuildBot/Helpers/Endpoints.Test.cs 22 yes Using member 'Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.MapGet(IEndpointRouteBuilder, String, Delegate)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. This API may perform reflection on the supplied delegate and its parameters. These types may be trimmed if not directly referenced.
DotNet IL2026 error src/BuildBot/Helpers/Endpoints.GitHub.cs 19 yes Using member 'Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.MapPost(IEndpointRouteBuilder, String, Delegate)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. This API may perform reflection on the supplied delegate and its parameters. These types may be trimmed if not directly referenced.
DotNet IL2026 error src/BuildBot/Helpers/Endpoints.GitHub.cs 29 yes Using member 'Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.MapPost(IEndpointRouteBuilder, String, Delegate)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. This API may perform reflection on the supplied delegate and its parameters. These types may be trimmed if not directly referenced.
DotNet IL2026 error src/BuildBot/Helpers/Endpoints.GitHub.cs 39 yes Using member 'Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.MapPost(IEndpointRouteBuilder, String, Delegate)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. This API may perform reflection on the supplied delegate and its parameters. These types may be trimmed if not directly referenced.
DotNet IL2026 error src/BuildBot/obj/Release/net11.0/Microsoft.AspNetCore.Http.RequestDelegateGenerator/Microsoft.AspNetCore.Http.RequestDelegateGenerator.RequestDelegateGenerator/GeneratedRouteBuilderExtensions.g.cs 1014 yes Using member 'Microsoft.AspNetCore.Http.HttpResponseJsonExtensions.WriteAsJsonAsync(HttpResponse, TValue, JsonSerializerOptions, CancellationToken)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Simplify clean - advancing to code review. (Note: the earlier Roslyn analyzer SARIF report lists only pre-existing, already-suppressed findings in files outside this PR's diff - no action needed.)

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Code review clean - advancing to security review

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Security review clean, advancing to coverage check

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Non-code change - coverage ratchet skipped

@dnyw4l3n13 dnyw4l3n13 added the Blocked Blocked by a dependency or external factor label Sep 19, 2026
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

This PR's automation idle-invocation budget (5) is exhausted with no known blocking reason — no required check has failed and there is no unaddressed review request. Blocking this PR until a human investigates.

Last session's diagnostic:

- Bash: gh api user --jq '.login' 2>&1; echo "---checks---"; gh pr checks 412 --repo funfair-tech/BuildBot 2>&1; echo "---closing issues---"; gh pr view 412 --repo funfair-tech/BuildBot --json closingIssuesReferences --jq '.closingIssuesReferences' 2>&1
- Bash: for attempt in 1 2 3; do   ACTUAL=$(gh api graphql \     -f query='query($i:ID!){node(id:$i){... on ProjectV2Item{fieldValueByName(name:"Workflow Status"){... on ProjectV2ItemFieldSingleSelectValue{optionId}}}}}' \     -f i="PVTI_lADOAcCjJ84BbqkUzg7s9Ws" \     --jq '.data.node.fieldValueByName.optionId')   [ "$ACTUAL" = "04605c38" ] && break   sleep "$attempt" done echo "ACTUAL=$ACTUAL"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-pr Pull request created automatically Blocked Blocked by a dependency or external factor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants