[repo-assist] Tests: add coverage for zipWithIndexAsync and ofIQueryable - #352
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…eryable Both functions previously had no dedicated test coverage. zipWithIndexAsync is an obsolete alias for mapiAsync (retained for backward compatibility); ofIQueryable casts an IQueryable<'T> to IAsyncEnumerable<'T> for LINQ provider integrations such as EF Core. No functional changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for two previously-untested public API functions:
AsyncSeq.zipWithIndexAsync— an obsolete alias forAsyncSeq.mapiAsync, kept for backward compatibility. Tests verify it behaves identically tomapiAsync(matching indices, values, and empty-sequence behavior).AsyncSeq.ofIQueryable— casts anIQueryable<'T>toIAsyncEnumerable<'T>, intended for interop with LINQ providers (e.g. EF Core'sDbSet) that implement both interfaces. Since the repo has no EF Core dependency, tests use a minimal custom type implementing bothIQueryable<'T>andIAsyncEnumerable<'T>to exercise the cast and enumeration path.No functional changes — this is purely additive test coverage, following the pattern of prior test-coverage PRs (#329, #343, #346).
Test Status
dotnet build FSharp.Control.AsyncSeq.sln -c Release— succeeded, 0 errors (5 pre-existing unrelated warnings aboutgroupBy/groupByAsyncconsumption).dotnet test tests/FSharp.Control.AsyncSeq.Tests -c Release— 500/500 tests passed (495 pre-existing + 5 new).🤖 This PR was created by Repo Assist, an automated AI assistant, as part of scheduled testing-improvement maintenance (Task 9). A human maintainer should review before merging.
Add this agentic workflow to your repo
To install this agentic workflow, run