Skip to content

[material_ui] Migrate M3 Card defaults to new gen_defaults - #12795

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:card_m3_defaults_migration
Sep 10, 2026
Merged

[material_ui] Migrate M3 Card defaults to new gen_defaults#12795
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:card_m3_defaults_migration

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

Work towards flutter/flutter#187899

Fixes flutter/flutter#188406

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 9, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 9, 2026
@QuncCccccc QuncCccccc added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the Material 3 Card defaults generation to a new template-based generator (CardTemplateM3). It replaces the inline default classes in card.dart with generated part files, enables the generator in gen_defaults.dart, and adds corresponding unit tests in gen_defaults_test.dart. No review comments were provided, so there is no feedback to address.

@QuncCccccc
QuncCccccc requested a review from elliette September 9, 2026 00:22
@QuncCccccc
QuncCccccc force-pushed the card_m3_defaults_migration branch from a0ec922 to 6c205e4 Compare September 9, 2026 19:26

@elliette elliette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@QuncCccccc
QuncCccccc force-pushed the card_m3_defaults_migration branch from 6c205e4 to 43cb131 Compare September 10, 2026 02:48
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2026
@auto-submit
auto-submit Bot merged commit 2fa9692 into flutter:main Sep 10, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

card_template.dart

2 participants