Skip to content

Sync release-material_ui-1.2.0 to main - #12788

Closed
fluttergithubbot wants to merge 1 commit into
mainfrom
release-material_ui-1.2.0
Closed

fluttergithubbot wants to merge 1 commit into
mainfrom
release-material_ui-1.2.0

Conversation

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This automated PR syncs the changes from the release branch release-material_ui-1.2.0 back to the main branch.

This PR was created automatically to batch release the `material_ui`.
@fluttergithubbot fluttergithubbot added the override: batch-material_ui material_ui batch release PR label Sep 8, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 8, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the version of the material_ui package to 1.2.0, updates the CHANGELOG.md with the release notes, and removes temporary changelog files. Feedback is provided to correct a grammatical inconsistency in one of the changelog entries to match the third-person singular present tense used in the other entries.

## 1.2.0

- Adds the `StyleVariant` enum defining the Material 3 and Material 3 Expressive style variants.
- Fix RangeSlider thumb overlay remaining visible after touch interaction

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the other changelog entries in this release, please use the third-person singular present tense ("Fixes" instead of "Fix") and add a trailing period.

Suggested change
- Fix RangeSlider thumb overlay remaining visible after touch interaction
- Fixes RangeSlider thumb overlay remaining visible after touch interaction.

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks closed this Sep 10, 2026
@Piinks

Piinks commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

This ended up in conflict, I think it got out of order with last week's release and this week's. @chunhtai will this just fix itself on the next run?

@chunhtai

chunhtai commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

the sync back need to land first before next release went out

otherwise, the change log will duplicate because those old entry is not cleaned up, but other than that it won't have any issue with the actual released code

@chunhtai

Copy link
Copy Markdown
Contributor

if the bot can't create a compatible pr, you can also manually create a branch from release-material_ui-1.2.0 with some conflict resolution and merge it into main with the override: batch-material_ui label

@chunhtai

Copy link
Copy Markdown
Contributor

once that is done, you can retrigger the batch release github action to generate a fresh release pr

@chunhtai

Copy link
Copy Markdown
Contributor

let me adjust the ci to see if i can do something to avoid this situation

@chunhtai chunhtai reopened this Sep 10, 2026
@fluttergithubbot

Copy link
Copy Markdown
Contributor Author

An existing Git SHA, b3c3ac009e69d2843fcd98cff19bfde59ec3d913, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@chunhtai chunhtai closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: batch-material_ui material_ui batch release PR p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants