Skip to content

[material_ui] Migrate M3 buttons template to use new gen_defaults - #12744

Open
QuncCccccc wants to merge 2 commits into
flutter:mainfrom
QuncCccccc:button_m3_defaults_migration
Open

[material_ui] Migrate M3 buttons template to use new gen_defaults#12744
QuncCccccc wants to merge 2 commits into
flutter:mainfrom
QuncCccccc:button_m3_defaults_migration

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

Work towards flutter/flutter#187899

Fixes flutter/flutter#188405

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 3, 2026
@QuncCccccc
QuncCccccc force-pushed the button_m3_defaults_migration branch 2 times, most recently from c982306 to c3c6211 Compare September 3, 2026 23:56
@QuncCccccc QuncCccccc changed the title [material_ui] Migrate M3 buttons template to use new gen_defaults [material_ui] Migrate M3 ElevatedButton template to use new gen_defaults Sep 4, 2026
@QuncCccccc
QuncCccccc force-pushed the button_m3_defaults_migration branch 13 times, most recently from bc042ae to e5653f7 Compare September 4, 2026 02:13
@QuncCccccc
QuncCccccc force-pushed the button_m3_defaults_migration branch from e5653f7 to a5b9d6d Compare September 4, 2026 02:17
@QuncCccccc
QuncCccccc marked this pull request as ready for review September 4, 2026 02:17
@QuncCccccc
QuncCccccc requested a review from elliette September 4, 2026 02:18
@QuncCccccc QuncCccccc changed the title [material_ui] Migrate M3 ElevatedButton template to use new gen_defaults [material_ui] Migrate M3 buttons template to use new gen_defaults Sep 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates Material 3 button defaults to be generated from tokens via a new ButtonTemplateM3 template, removing hardcoded default classes from the button implementation files and generating them as part files instead. The review feedback suggests modernizing the generated code by replacing deprecated MaterialStatePropertyAll references with WidgetStatePropertyAll in both the template and its associated tests.

Comment thread packages/material_ui/tool/gen_defaults/test/gen_defaults_test.dart
@QuncCccccc

Copy link
Copy Markdown
Contributor Author

All comments from gemini-code-assist are related to replace MaterialStatePropertyAll with WidgetStatePropertyAll . I resolved them all with no change because we want to keep the original code as is.

@QuncCccccc QuncCccccc added CICD Run CI/CD override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

button_template.dart

1 participant