Lifecycle: a panicking worker is a failed worker - #50
Merged
Conversation
The Go worker was the one user function not called through callHook, so a panic in it escaped its goroutine and took the process down with no OnStop run and no event emitted, where a panicking hook became that hook's error. It now goes through callHook like the rest: the panic is the worker's error, Shutdown receives it, Run returns it, OnStop runs and the stop event carries it. TestPanickingWorkerIsAFailure pins it and crashes against c44198f with "panic: consumer exploded". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Goworker was the one user function not called throughcallHook(lifecycle.go, the worker goroutine), so a panic in it escaped the goroutine and took the process down with noOnStoprun and no event emitted, where a panickingOnStart,OnDrainorOnStopbecomes that hook's error. CLAUDE.md's invariant says every hook goes through the wrapper; this one did not.It now goes through
callHooklike the rest. The panic is the worker's error and takes the existing path: wrapped once, handed toShutdown, reported byStop, returned byRun, withOnStoprun and the stop event carrying the failure.TestPanickingWorkerIsAFailureinworker_test.gochecks all four. It passes here and, run against a clone of c44198f, crashes withpanic: consumer exploded.Behaviour change, no signature change: a CHANGELOG entry under Unreleased as Fixed, and the CLAUDE.md invariant now names the worker. Full gate passes (gofmt, vet, race suite, golangci-lint, embedmd). Intended for 0.16.1.
🤖 Generated with Claude Code