Repository navigation
recipes: version bumps, part 1 - #135
Merged
Merged
Conversation
Bump 1.1.2 -> 1.2.4 (security fixes GHSA-j586-36cw-2gc2, GHSA-j8c6-9vc5-hj6x). Add a test that the C extension, not msgpack's silent pure-Python fallback, is the implementation in use.
20261020's cibuildwheel iOS block swaps in raw xcrun clang++, which links the simulator slice as device iOS. The recipe already passes those settings.
curl-impersonate 2.2.3+ resolves DNS through c-ares on iOS, and every lookup times out on the iOS simulator (curl 28); 0.16.2 makes the same requests in the same app. Android is unaffected upstream, but one version for both keeps the recipe simple. armeabi-v7a stays excluded: 2.2.2 has no 32-bit ARM asset. The tarballs ship their own licence notices, so the vendored copies go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part 1 of bringing recipes up to their latest upstream releases: ten recipes, one commit each.
setup-13.x.patch: 13.0 reworked thesys.prefixlookup our patch edits. 12.x keeps its own.skip-upstream-ios-cross.patch, see below.Why not the latest everywhere
curl-cffi stops at 0.16.3. 0.17.0 needs curl-impersonate 2.3.x, whose iOS build resolves DNS through c-ares. On the iOS simulator every request then fails with
curl: (28) Resolving timed out. The same app on 0.16.2 makes 5 of 5 requests. Upstream moved Android back to the threaded resolver (lexiforest/curl-impersonate#339, #344) but not iOS. 2.2.2 still uses the threaded resolver, and the example app makes 5 of 5 requests on 0.16.3. flet-libcurl-impersonate now ships the licence notices from upstream's tarballs instead of vendored copies.ncnn iOS on 3.13/3.14 is a known failure. 20261020 added a cibuildwheel iOS block to
setup.pythat swaps forge's compiler wrappers for rawxcrun clang++, so the simulator slice linked as device iOS. The patch skips that block whenEXTRA_CMAKE_ARGSis set, and all our iOS slices now build asMH_DYLIB. But on cp313/cp314, PyPI's own ncnn wheels are taggedios_14_0against ourios_13_0, and the platform tag outranks our build tag. Their extension isMH_BUNDLE, which Flet's iOS link rejects. Any Flet that acceptsios_14_0wheels already gets those upstream wheels, whatever version we ship. Android and cp312 iOS get ours. Follow-up: tag our ncnn iOS wheelsios_14_0(the binary'sminosis already 14.0).Validation
On-device recipe tests on Android and iOS, Python 3.12–3.14:
curl-cffi's tests make no network calls, so its example app was also run on an iOS simulator against the CI wheels, making real HTTPS requests.
Two Android 3.12 jobs failed on a Gradle download in serious_python (a zero-filled ETag JSON) and passed on retry. That flake is unrelated to these recipes.