chore(example): prepare for upgrade to built-in Kotlin - #2252
Merged
Conversation
Redesign drawer header to incorporate small box to ask users to use Live Web Demo responsibly Display attribution on every page (open by default on home page only) Wrap OSM `TileLayer` into stateless widget
JaffaKetchup
changed the title
JaffaKetchup
marked this pull request as ready for review
September 3, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flutter 3.47 supports built-in Kotlin. To best prepare for this, we should remove shared_preferences:
shared_preferences_android needs to be upgraded to support built-in Kotlin. However, this requires version 3.12 of the Dart SDK, while we currently support 3.6. To ensure that we can build on Flutter 3.27 to prove that flutter_map works on that version, shared_preferences must therefore be removed. This comes with other benefits as well (makes the app smaller, faster, less complicated, 100% cookie free). Therefore, a small redesign is required to remove the first-time popup previously presented to Live Web Demo users which asked them to use the demo responsibly, and used shared_preferences to store whether it was a user's first visit. Therefore, this message has been moved into the drawer header (as shown in the image below). To reduce the intrusiveness of the attribution popup on first load, the sentence there has also been removed, and instead the attribution is now available on every page (although it still only opens by default on the home page). To save space, and because the attribution widget now shows the flutter_map logo, the logo has been removed from next to the menu button.
Once upgraded to built-in Kotlin on v3.47, it will no longer be buildable for any version less than 3.47 (or maybe 3.44, I'm not sure), unless we maintain two separate build configs.