Conversation
…on the auth-flow switch label
…theming of text fields and CTA buttons
…se remaining unstyled-text gaps across the auth flow
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a customizable styling and typography system for the authentication flow, including AuthCTAButtonStyle for primary buttons, AuthTextFieldStyle for text fields, and AuthTypography for custom font families. The feedback highlights three key issues: a double-scaling bug in AuthTypography when resolving custom fonts with Dynamic Type, a regression in AuthCTAButtonModifier where passing a nil background color clears the inherited environment tint, and a visual regression in EmailAuthView where the blue color of the switch-auth-flow action label was accidentally removed.
demolaf
marked this pull request as ready for review
September 25, 2026 11:23
- CTA labels fall back to body, not headline, so unthemed buttons keep their weight - Provider buttons keep the system font; Delete Account stays red under a CTA theme - Make the no-argument authCTAButtonStyle() and AuthFontModifier internal - Rename AuthTypography.fontFamily to fontName - Re-apply the custom font to verification code boxes on update - Move MFAResolutionView onto VerificationCodeInputField and shared button styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds environment-driven theming for the SwiftUI auth flow's text fields, CTA buttons and typography. Unset values keep today's exact appearance. First of the PRs splitting up #1400.
Changes
AuthTextFieldStyle,AuthCTAButtonStyleandAuthTypography, each set with aViewmodifier and carried through the environment so they reach pushed screens inside the auth sheet..buttonStyle(.borderedProminent)and.font(_:)calls across the auth screens with.authCTAButtonStyle()and.authFont(_:weight:). Brand-styled provider buttons and the Delete Account button are unchanged.AuthTypographyto typed text andAuthTextFieldStyleto the verification code boxes, not justAuthTextField.MFAResolutionViewontoVerificationCodeInputFieldand the shared button styles, so theming reaches it like the other MFA screens.FirebaseAuthUIComponentsfromFirebaseAuthSwiftUI. It is not a library product, soAuthTextFieldStyleandAuthTypographywere otherwise unreachable fromimport FirebaseAuthSwiftUI.API Usage
Preview
Maintainer note: Fixes internal CPRN-515