refactor!: conclude allows multiple receipts in a single invocation - #73
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
Add DAG-JSON coverage for decoding an empty receipt list.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Refactors /ucan/conclude to support multiple receipt CIDs across CBOR and DAG-JSON.
Changes:
- Replaces
ReceiptwithReceipts []cid.Cid. - Updates CBOR and DAG-JSON codecs.
- Adds single, multiple, and empty-list tests.
File summaries
| File | Summary |
|---|---|
commands/ucan/types.go |
Defines the receipt list argument. |
commands/ucan/json_gen.go |
Encodes and decodes receipt arrays in DAG-JSON. |
commands/ucan/codec_test.go |
Tests receipt-list codec behavior. |
commands/ucan/cbor_gen.go |
Encodes and decodes receipt arrays in CBOR. |
Review details
Files not reviewed (2)
- commands/ucan/cbor_gen.go: Generated file
- commands/ucan/json_gen.go: Generated file
- Files reviewed: 2/4 changed files
- Comments generated: 1
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
No unresolved review issues were identified.
Review details
Files not reviewed (2)
- commands/ucan/cbor_gen.go: Generated file
- commands/ucan/json_gen.go: Generated file
- Files reviewed: 2/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conclude arguments
receipt: Linkbecomesreceipts: [Link].