WM (Linux): supports Umbriel version detection - #2594
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds version detection support for the Umbriel Wayland compositor, part of the Noctalia ecosystem. Fastfetch already detects the compositor's process name (
umbriel) via its generic Wayland detection, but{version}came back empty since no parser existed for it.Related issue (required for new logos for new distros)
Changes
getUmbriel()insrc/detection/wm/wm_linux.c, following the same pattern used forniri: runsumbriel --version, which outputsumbriel 0.1.0 (7a448abe550e), and extracts the version by cutting after the first space and before the last(.umbrielin theffDetectWMVersiondispatch, alongside the other Wayland compositors.Full
--format jsonoutput for the WM module:{ "type": "WM", "result": { "processName": "umbriel", "prettyName": "umbriel", "protocolName": "Wayland", "pluginName": "", "version": "0.1.0" } }Checklist
Screenshots
N/A
Checklist