Conversation
FreeBSD (and other systems that build ImageMagick without encoding the quantum depth into the library name) install libMagickCore-7.so and libMagickCore-6.so without a .Q16HDRI / .Q16 suffix. dlopen currently only tries the suffixed names, so image logos always fall back to ASCII art with "Image Magick library not found" even when ImageMagick is installed. Append the plain library names as a last resort.
Also moves NSWorkspace method to the last method to try Fixes #2559
C_STANDARD C17 and C23 were only introduced in CMake 3.21
Co-authored-by: Vladimir Romanov <rirusha@altlinux.org>
Distro discontinued #2567
/proc/cpuinfo on sparc has none of the fields the generic fallback looks for, so the module printed "Unknown (64)". The name is in "cpu", and the frequency in "Cpu<n>ClkTck" -- in Hz, hex on sparc64, decimal on sparc32.
Bumps the github-actions group with 3 updates: [github/codeql-action/init](https://github.com/github/codeql-action), [github/codeql-action/analyze](https://github.com/github/codeql-action) and [vmactions/solaris-vm](https://github.com/vmactions/solaris-vm). Updates `github/codeql-action/init` from 4.37.8 to 4.37.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@db488dd...cdf488f) Updates `github/codeql-action/analyze` from 4.37.8 to 4.37.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@db488dd...cdf488f) Updates `vmactions/solaris-vm` from 1.3.8 to 1.3.9 - [Release notes](https://github.com/vmactions/solaris-vm/releases) - [Commits](vmactions/solaris-vm@315163f...96d8d97) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action/analyze dependency-version: 4.37.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: vmactions/solaris-vm dependency-version: 1.3.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…winget package detection
.. to avoid `SQLITE_READONLY` errors
for ffStrbufMatchSeparatedNS and ffStrbufSeparatedContainNS Fixes #2585
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Platform-specific process handling, image decoding, schema coverage, and release metadata contain correctness issues that should be resolved before release.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prepares v2.69.0 with expanded image-logo support, platform detection improvements, networking fixes, and updated tests/documentation.
Changes:
- Adds animation, caching, native image backends, and embedded sixel support.
- Improves networking, process, package, and platform detection.
- Updates release documentation, presets, dependencies, and CI.
File summaries
| File | Description |
|---|---|
| tests/strbuf.c | Expands separated-string tests. |
| tests/networking.c | Adds HTTP framing tests. |
| tests/base64.c | Adds Base64 regression tests. |
| src/options/logo.h | Adds cache and animation options. |
| src/options/logo.c | Parses and emits new logo options. |
| src/modules/zpool/zpool.c | Marks key-format variables. |
| src/modules/swap/swap.c | Marks key-format variables. |
| src/modules/physicaldisk/physicaldisk.c | Marks key-format variables. |
| src/modules/packages/packages.c | Exposes CRUX package counts. |
| src/modules/packages/option.h | Adds CRUX package flag. |
| src/modules/os/os.c | Marks key-format variables. |
| src/modules/netio/netio.c | Renames key variable and lowers wait time. |
| src/modules/monitor/monitor.c | Marks key-format variables. |
| src/modules/localip/localip.c | Marks key-format variables. |
| src/modules/display/display.c | Marks key-format variables. |
| src/modules/diskio/diskio.c | Lowers wait time and updates metadata. |
| src/modules/disk/disk.c | Marks key-format variables. |
| src/modules/cpucache/cpucache.c | Adds cache-level formatting. |
| src/modules/codec/codec.c | Marks key-format variables. |
| src/modules/btrfs/btrfs.c | Marks key-format variables. |
| src/modules/brightness/brightness.c | Marks key-format variables. |
| src/modules/bluetoothradio/bluetoothradio.c | Marks key-format variables. |
| src/modules/bios/bios.c | Marks key-format variables. |
| src/modules/battery/battery.c | Renames battery name variable. |
| src/logo/logo.h | Gates image declarations. |
| src/logo/logo.c | Gates image rendering and optimizes colors. |
| src/logo/image/sixel.c | Adds embedded sixel encoding. |
| src/logo/image/image.h | Defines the new image backend API. |
| src/logo/image/im6.c | Reworks ImageMagick 6 encoding. |
| src/logo/ascii/z/zerene.txt | Removes Zerene logo data. |
| src/logo/ascii/z.inc | Removes Zerene registration. |
| src/logo/ascii/a/alt_atomic.txt | Adds ALT Atomic artwork. |
| src/logo/ascii/a.inc | Registers ALT Atomic. |
| src/flashfetch.c | Aligns flashfetch output defaults. |
| src/fastfetch.c | Documents key-format variables. |
| src/detection/wm/wm_windows.c | Uses newer Windows process APIs. |
| src/detection/weather/weather.c | Supplies HTTP port. |
| src/detection/wallpaper/wallpaper_apple.m | Reworks macOS wallpaper detection. |
| src/detection/top/top.c | Simplifies sampling preparation. |
| src/detection/top/top_obsd.c | Replaces kvm with sysctl. |
| src/detection/top/top_apple.c | Reworks macOS process snapshots. |
| src/detection/terminalfont/terminalfont_windows.c | Supports Windows Terminal fragments. |
| src/detection/swap/swap_linux.c | Prevents 64-bit truncation. |
| src/detection/sound/sound_nosupport.c | Removes unsupported fallback. |
| src/detection/publicip/publicip.c | Adds custom-port parsing. |
| src/detection/processes/processes_windows.c | Adds direct process-count lookup. |
| src/detection/processes/processes_obsd.c | Replaces kvm with sysctl. |
| src/detection/processes/processes_apple.c | Handles inaccessible process details. |
| src/detection/physicalmemory/physicalmemory_apple.m | Prevents 64-bit truncation. |
| src/detection/physicaldisk/physicaldisk_linux.c | Prevents 64-bit truncation. |
| src/detection/packages/packages.h | Stores CRUX count. |
| src/detection/packages/packages.c | Unifies cache mtime handling. |
| src/detection/packages/packages_windows.c | Restricts winget source. |
| src/detection/packages/packages_linux.c | Detects CRUX packages. |
| src/detection/netio/netio.c | Uses monotonic, fractional timing. |
| src/detection/lm/lm_linux.c | Replaces OpenBSD kvm usage. |
| src/detection/initsystem/initsystem_windows.c | Uses newer Windows process APIs. |
| src/detection/gpu/gpu_sunos.c | Prevents 64-bit truncation. |
| src/detection/gpu/gpu_linux.c | Narrows revision storage. |
| src/detection/gpu/gpu_apple.m | Updates compiler diagnostics. |
| src/detection/displayserver/linux/wmde.c | Adds COSMIC and removes kvm. |
| src/detection/displayserver/displayserver.h | Defines COSMIC name. |
| src/detection/diskio/diskio.c | Uses monotonic, fractional timing. |
| src/detection/de/de_linux.c | Reads COSMIC environment version. |
| src/detection/cpu/cpu.c | Adds newer Apple CPU names. |
| src/detection/cpu/cpu_linux.c | Adds SPARC and MediaTek updates. |
| src/common/windows/nt.h | Adds newer Windows information classes. |
| src/common/networking.h | Expands HTTP APIs. |
| src/common/io.h | Adds portable mtime lookup. |
| src/common/impl/settings.c | Refactors SQLite reads. |
| src/common/impl/processing_linux.c | Removes OpenBSD kvm usage. |
| src/common/impl/option.c | Honors bright key/title colors. |
| src/common/impl/networking_windows.c | Adds ports and chunked responses. |
| src/common/impl/networking_common.c | Implements shared HTTP framing. |
| src/common/impl/io_windows.c | Adds Unicode removal and mtime lookup. |
| src/common/impl/io_unix.c | Adds Unix mtime lookup. |
| src/common/impl/init.c | Reports embedded sixel. |
| src/common/impl/FFstrbuf.c | Corrects empty separated segments. |
| src/common/impl/FFPlatform_unix.c | Removes OpenBSD kvm usage. |
| src/common/impl/commandoption.c | Merges configured module options. |
| src/common/impl/base64.c | Fixes signed-byte encoding. |
| src/3rdparty/yyjson/repo.json | Updates yyjson metadata. |
| src/3rdparty/sixel/status.h | Vendors libsixel status API. |
| src/3rdparty/sixel/repo.json | Records libsixel metadata. |
| src/3rdparty/sixel/quant.h | Vendors quantizer API. |
| src/3rdparty/sixel/output.h | Vendors output internals. |
| src/3rdparty/sixel/output.c | Vendors output implementation. |
| src/3rdparty/sixel/malloc_stub.h | Vendors allocation compatibility API. |
| src/3rdparty/sixel/LICENSE.sixel | Adds sixel source license. |
| src/3rdparty/sixel/LICENSE.pnmcolormap | Adds quantizer license. |
| src/3rdparty/sixel/LICENSE | Adds libsixel license. |
| src/3rdparty/sixel/dither.h | Vendors dither internals. |
| src/3rdparty/sixel/config.h | Configures vendored libsixel. |
| src/3rdparty/sixel/allocator.h | Vendors allocator API. |
| src/3rdparty/sixel/allocator.c | Vendors allocator implementation. |
| presets/neofetch.jsonc | Aligns neofetch-compatible defaults. |
| presets/ci.jsonc | Reorders sampled modules. |
| presets/all.jsonc | Reorders sampled modules. |
| doc/json_schema.json | Documents release configuration changes. |
| doc/help.json | Documents logo cache and animation. |
| debian/changelog.tpl | Adds Debian release entry. |
| CHANGELOG.md | Documents v2.69.0. |
| .gitignore | Updates work-directory exclusions. |
| .github/workflows/build-solaris-amd64.yml | Updates Solaris VM action. |
| .github/workflows/build-no-features-test.yml | Disables image logos in minimal build. |
| .github/workflows/build-macos-hosts.yml | Updates macOS dependency setup. |
| .github/workflows/build-linux-loong64.yml | Updates QEMU action. |
| .github/workflows/build-linux-i686.yml | Corrects cross-build configuration. |
| .github/workflows/build-linux-hosts.yml | Updates CodeQL actions. |
Review details
- Files reviewed: 123/125 changed files
- Comments generated: 7
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codec (Android): uses `availability` feature test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist