Repository navigation
Conversation
psiha
force-pushed
the
feat/resource-recording
branch
from
November 3, 2026 23:34
1450e3c to
2c741aa
Compare
psiha
force-pushed
the
feat/open-import-series
branch
2 times, most recently
from
November 3, 2026 23:50
01d8146 to
ff0d92b
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request due to rate limiting. Please try again later. See Usage limits for GitHub Copilot for details.
R8 keeps its total time and also reports openTime and firstReadTime. After its timed runs, one untimed open gives rssMB.afterOpen, taken before any read. Optional --cached-open N reopens the same files, in the page cache, and reports them unscored. --drop-caches empties the page cache after each R8 setup (root or passwordless sudo, else it says so); it is machine-wide, so the result records it as env.dropCaches. The extra opens come after the test's readings and always stop the system. Additive: no existing field changes. Refs #25 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
psiha
force-pushed
the
feat/resource-recording
branch
from
November 5, 2026 10:10
2c741aa to
f5af631
Compare
psiha
force-pushed
the
feat/open-import-series
branch
from
November 5, 2026 10:10
ff0d92b to
00af6df
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #25. Stacked on #50 (this PR's base is that branch, so the diff shows only this change; GitHub retargets it to
mainwhen #50 merges).What
Opening a database gets its own numbers, and the memory at rest is recorded. All additive, and
timeis untouched.time(open, then the first read). It also reportsopenTime,firstReadTimeandopenRuns, measured at the boundary inside the same run. No timer is added around anything new.resources.rssMB.afterOpen: the memory once the model is open.--cached-open N(optional, R8 only). After the timed runs, opens the same filesNmore times, in the page cache, and reportscachedOpenTime,cachedFirstReadTime,cachedOpenRuns. Marked "not scored". These extra opens always stop the system, even when one fails.--drop-caches(optional, R8 only). Empties the page cache after each R8 setup, before the open, and recordspageCacheas "dropped before each open" or "not emptied". It needs root or passwordlesssudo. If it cannot, it says so at the start and R8 runs as before. The page cache belongs to the whole host, so the flag also empties it for every other process and for the tests after R8. The result records it asenv.dropCaches, and the README says results with and without it are not comparable for those tests.rssMB.afterOpenis taken before any read. The extra opens come after the test's readings (from #50), so its CPU, IO and peak memory do not include them.Importing needs no new test: L1 is the import (and L2 and L3 are loads),
timeis its time, and #50 adds its memory, CPU, disk and IO. The runner README says so.Blind spots it removes
R8 mixed the start of the system with the first read, and the page cache state was not recorded. The setup copies the snapshot and syncs just before the open, so the files are normally still in the page cache: R8 is cold for the process, not for the cache, unless
--drop-cachesis used. The README says so; it does not change how R8 is scored.Schema
Additive, in R8's summary:
openTime,firstReadTime,openRuns,pageCache, and with the flagcachedOpenTime,cachedFirstReadTime,cachedOpenRuns,cachedNote; plusresources.rssMB.afterOpenandenv.dropCaches. The website, the scores and the other R8 work (R8 counted in the cold read score only) readtime, which does not change.How it was checked
On a Linux box, 10m,
--quick, in a container, after the rebase onto #50:--tests R8 --cached-open 2 --drop-caches:openTime+firstReadTimeequalstime, 2 cached opens are reported,afterOpenis present, the check isok. The container could not empty the cache, so the warning was printed,pageCachesaid "not emptied" andenv.dropCacheswas false.Not checked:
--drop-cacheswhere it is allowed (it would empty the cache of a shared machine), the newfinallyafter a failed extra open, DuckDB and PostgreSQL, 100m and 1b, full-size R8 runs (3 repeats).🤖 Generated with Claude Code