Repository navigation
Linux 0.1.1: widgets return to the desktop layer after arrange mode - #78
Merged
Merged
Conversation
After arrange mode the widget windows stayed on the overlay layer, above every window, until the shell was restarted. The service turns "on top" on while arranging and the plugin hides the widget windows meanwhile; a layer change around the time a window is hidden was not applied when it was shown again. The plugin now ignores "on top" during arrange mode, sets the layer only while the window is shown, and sets it once more after it is shown. The plugin's stand-in service now behaves like the real one here, which turns an existing check into the regression test: it fails with the old plugin and passes with this one. Also records the refresh checks on the desktop (schedule, manual, ticking date, timeline transitions) and the run of the x86_64 archive on the Omarchy 4.5 test machine through emulation. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fixes a bug in the Linux preview 0.1.0: after arrange mode was used, every widget stayed above all windows until the Omarchy shell was restarted. No issue linked.
Cause and fix
While arranging, the service turns "on top" on and restores it afterwards, and the plugin hides the widget windows. A layer change made around the time a window is hidden was not applied when the window was shown again, so it came back on the overlay layer.
Linux/omarchy-plugin/WidgetWindow.qmlnow ignores "on top" during arrange mode, sets the layer only while the window is shown, and sets it once more after it is shown.Only the plugin changes; the service, the command line and the protocol are the same. Version 0.1.1.
Security and compatibility
None: no contract, protocol or permission change.
What ran (aarch64 Omarchy 4.5 virtual machine)
Linux/omarchy-plugin/tests/check.sh, whose stand-in now turns "on top" on while arranging like the real service: 64 of 64 with this change; with the oldWidgetWindow.qmlthe layer check after arrange fails.docs/linux/testing.md, done with the 0.1.0 archives: scheduled, manual, ticking-date and timeline refresh on the desktop; and the x86_64 archive run on the same machine through instruction emulation, showing and operating widgets and opening the management window.Not run
./Scripts/release-readiness.shlocally: it does not cover Linux.🤖 Generated with Claude Code