-
Notifications
You must be signed in to change notification settings - Fork 30
feat(state_machine): generate the example's HFSM from its model at build time #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ae8ad58
feat(state_machine): generate the example's HFSM from its model at bu…
finger563 2a01d0b
Generate only the machine, using the generator's --no-support
finger563 4b8bc7d
Use the released generator from npm now that v1.8.0 is out
finger563 92f5aee
fix(state_machine): address #776 review — node>=18 guard, non-interac…
finger563 b29c8ee
Make HFSM generation a function the component provides
finger563 d7c2478
Sort generated HFSM sources
Copilot 9aa95ec
Harden HFSM generation and Node setup
Copilot d91afc4
Merge branch 'main' into feature/generate-hfsm-in-build
finger563 910adeb
fix(state_machine): quote CI generator setup safely
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,19 @@ | ||
| idf_component_register(SRC_DIRS "." | ||
| INCLUDE_DIRS ".") | ||
| # The HFSM's C++ is GENERATED from Complex.json, not checked in: the | ||
| # model is the source, the C++ is a build product. | ||
| # | ||
| # espp_generate_hfsm comes from the state_machine component's | ||
| # project_include.cmake. ESP-IDF does not load those during its early | ||
| # requirements pass, so the call is guarded -- SRCS and INCLUDE_DIRS | ||
| # are not read in that pass either, and the empty variables below are | ||
| # what it expects to see. | ||
| if(NOT CMAKE_BUILD_EARLY_EXPANSION) | ||
| espp_generate_hfsm( | ||
| MODEL "${CMAKE_CURRENT_LIST_DIR}/Complex.json" | ||
| OUTPUT_DIR "${CMAKE_CURRENT_BINARY_DIR}/hfsm" | ||
| SOURCES_VAR hfsm_srcs | ||
| INCLUDE_DIR_VAR hfsm_inc) | ||
| endif() | ||
|
|
||
| idf_component_register( | ||
| SRCS "hfsm_example.cpp" ${hfsm_srcs} | ||
| INCLUDE_DIRS "." ${hfsm_inc}) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.